Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchTracking is not defauling to accessibilityLabel #3410

Closed
6 of 11 tasks
daniel-johns-99 opened this issue Nov 21, 2023 · 1 comment · Fixed by getsentry/sentry-docs#8540
Closed
6 of 11 tasks

TouchTracking is not defauling to accessibilityLabel #3410

daniel-johns-99 opened this issue Nov 21, 2023 · 1 comment · Fixed by getsentry/sentry-docs#8540

Comments

@daniel-johns-99
Copy link

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 5.13.0

react-native version: 0.68.0

Are you using Expo?

  • Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

(react-native-sentry)

export default Sentry.wrap(App);

The documentation mentions that by wrapping the App with Sentry we will get automatic Touch Tracking. https://docs.sentry.io/platforms/react-native/touchevents/ , The documentation also says that if no sentry-label is passed to a Component then Sentry will fallback to the accessibilityLabel Prop (https://docs.sentry.io/platforms/react-native/touchevents/#tracking-specific-components).

This is not working and the accessibilityLabel is not being seen in Sentry traces.

It appears that this behaviour was changed in #2712 however, is it a case of the documentation not being updated or is this accessibilityLabel prop still being read by default.

@krystofwoldrich
Copy link
Member

@daniel-johns-99 Thank you for the message, this is an oversight on our side.

This behavior was changed in 5.0.0 major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants