Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to disable Sentry after having configured it #320

Closed
confiks opened this issue Dec 29, 2017 · 3 comments
Closed

Possibility to disable Sentry after having configured it #320

confiks opened this issue Dec 29, 2017 · 3 comments
Assignees

Comments

@confiks
Copy link
Contributor

confiks commented Dec 29, 2017

First of all, thanks for making a great open source error reporting tool!

In our app, we want to give users the possibility to disable all error reporting. Currently, this doesn't seem to be possible with react-native-sentry. For Javascript, raven-js does have the option to call uninstall to disable error reporting, and in the Go implementation I can set the DSN to an empty string to do the same thing.

Could disabling error reporting become a supported feature of the react-native-sentry client?

@HazAT HazAT self-assigned this Dec 30, 2017
@HazAT
Copy link
Member

HazAT commented Dec 30, 2017

Hey,

Thank you for using Sentry :)

So "uninstalling" is not an easy task, there are many things that hook into the process so it's rather complex.
I would still give your users the possibility to disable it but only take effect after they restart they app. You can store the value, check it on startup and just don't call install() then.

Hope that helps

@HazAT HazAT closed this as completed Dec 30, 2017
@confiks
Copy link
Contributor Author

confiks commented Dec 30, 2017

An easier option that might work for react-native-sentry is to support updating the DSN after having called install. In that way error reporting to a remote server is disabled, without having to unhook all that complicated stuff, and without having to restart the app.

@paulomp90
Copy link

just wondering if this is still the only option? Do not call install, or there is another way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants