Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append missing context from Native SDK for iOS #2085

Closed
marandaneto opened this issue Feb 22, 2022 · 4 comments · Fixed by #2713
Closed

Append missing context from Native SDK for iOS #2085

marandaneto opened this issue Feb 22, 2022 · 4 comments · Fixed by #2713
Assignees
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Cocoa Platform: React-Native
Milestone

Comments

@marandaneto
Copy link
Contributor

Similar to https://github.com/getsentry/sentry-dart/pull/761/files

Missing tags, extra, user, dist, environment, fingerprint, level, breadcrumbs...
Ideally, every scope data set in the Native SDK makes it to the Events captured by JS as well.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@marandaneto marandaneto moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 18, 2022
@marandaneto marandaneto added this to the 5.0.0 milestone Dec 7, 2022
@marandaneto
Copy link
Contributor Author

Right RN -> iOS only merges the contexts and user, https://github.com/getsentry/sentry-react-native/blob/main/src/js/integrations/devicecontext.ts
But it should merge/fill the missing objects as well the tags, extra, dist, environment, fingerprint, level, breadcrumbs.

@krystofwoldrich
Copy link
Member

This might be a breaking change due to the inclusion of the event.fingerprint.

@krystofwoldrich krystofwoldrich added the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Jan 3, 2023
@marandaneto
Copy link
Contributor Author

This might be a breaking change due to the inclusion of the event.fingerprint.

That's fine, its part of the v5 milestone anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Cocoa Platform: React-Native
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants