diff --git a/CHANGELOG.md b/CHANGELOG.md index c71ee38e19..4655ed51d3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ - Fetch Organization slug from `@sentry/react-native/expo` config when uploading artifacts ([#3557](https://github.com/getsentry/sentry-react-native/pull/3557)) - Remove 404 Http Client Errors reports for Metro Dev Server Requests ([#3553](https://github.com/getsentry/sentry-react-native/pull/3553)) - Stop tracing Spotlight Sidecar network request in JS ([#3559](https://github.com/getsentry/sentry-react-native/pull/3559)) +- Upload Debug Symbols Build Phase continues when `node` not found in `WITH_ENVIRONMENT` ([#3573](https://github.com/getsentry/sentry-react-native/pull/3573)) ## 5.17.0 diff --git a/scripts/sentry-xcode-debug-files.sh b/scripts/sentry-xcode-debug-files.sh index 6427338768..b522ba5fe3 100755 --- a/scripts/sentry-xcode-debug-files.sh +++ b/scripts/sentry-xcode-debug-files.sh @@ -2,8 +2,8 @@ # Upload Debug Symbols to Sentry Xcode Build Phase # PWD=ios -# print commands before executing them and stop on first error -set -x -e +# print commands before executing them +set -x [ -z "$WITH_ENVIRONMENT" ] && WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh" @@ -12,6 +12,9 @@ if [ -f "$WITH_ENVIRONMENT" ]; then . "$WITH_ENVIRONMENT" fi +# stop on first error (we can't use -e before as any failed command in WITH_ENVIRONMENT would stop the debug files upload) +set -e + LOCAL_NODE_BINARY=${NODE_BINARY:-node} [ -z "$SENTRY_PROPERTIES" ] && export SENTRY_PROPERTIES=sentry.properties