Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance instrumentation for Sanic Integration #2388

Closed
antonpirker opened this issue Sep 21, 2023 · 0 comments · Fixed by #2419
Closed

Performance instrumentation for Sanic Integration #2388

antonpirker opened this issue Sep 21, 2023 · 0 comments · Fixed by #2419
Assignees

Comments

@antonpirker
Copy link
Member

Problem Statement

Currently the SanicIntegration does not start transactions for a request-response-cycle.

Solution Brainstorm

If Sanic is a WSGI based framework we maybe can use SentryWsgiMiddleware like bottle does:
https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/bottle.py

If not we can have a look at how the low level WSGI integration creates transactions (and continues traces from incoming requests): https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/wsgi.py#L97-L115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants