Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode version string in src/raven.js (fixes GH-465) #470

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Conversation

benvinegar
Copy link
Contributor

Note src/raven.js specifies 2.0.0 because this is the current value of version in package.json on master.

When I cherry-pick this into stable/2.0.x, I will update the version string.


Grunt output when attempting to run grunt dist or grunt build when version mismatches:

➜  raven-js git:(master) ✗ grunt dist
Running "clean:0" (clean) task
>> 1 path cleaned.

Running "gitinfo" task

Running "version" task
Warning: Mismatched version in src/raven.js: 2.1.0 (should be 2.0.0) Use --force to continue.

Aborted due to warnings.
➜  raven-js git:(master) ✗ grunt build
Running "clean:0" (clean) task
>> 0 paths cleaned.

Running "gitinfo" task

Hardcode version string in src/raven.js (fixes GH-465)
Running "version" task
Warning: Mismatched version in src/raven.js: 2.1.0 (should be 2.0.0) Use --force to continue.

Aborted due to warnings.

@mattrobenolt
Copy link
Contributor

Shitty, but the assertion makes it more palatable. 👍

benvinegar added a commit that referenced this pull request Jan 12, 2016
Hardcode version string in src/raven.js (fixes GH-465)
@benvinegar benvinegar merged commit d69f074 into master Jan 12, 2016
@benvinegar benvinegar deleted the GH-465 branch January 12, 2016 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants