Added support for CommonJS/browserify. #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| // If there is no JSON, we no-op the core features of Raven | |||
| // since JSON is required to encode the payload | |||
| var _Raven = window.Raven, | |||
| hasJSON = !!(window.JSON && window.JSON.stringify), | |||
| hasJSON = !!(typeof JSON === 'object' && JSON.stringify), | |||
There was a problem hiding this comment.
I already have is isObject() helper.
Added support for strict CommonJS per UMDJS.
|
OK, give that latest commit some eyes. I added a global to the AMD section per UMDJS. I think that should do the trick. I don't use AMD so I have no way to easily test the AMD side of things. Do you have an AMD environment to give it a quick run through? I can confirm that it is working with browserify. |
|
I can test this later. That seems sorta sane. :) Still gross, but if it works... |
|
Nice, thanks for all your help Matt! 🍻 |
|
Bump on this, any chance we can get these changes merged so I can stop using my fork? 😜 |
mattrobenolt
added a commit
that referenced
this pull request
Nov 3, 2014
Added support for CommonJS/browserify.
|
Thanks for the merge @mattrobenolt! Hit me up if you'd like help testing, etc. Cheers 🍻! |
Closed
matghaleb
pushed a commit
to matghaleb/raven-js
that referenced
this pull request
Sep 9, 2015
Added support for strict CommonJS per UMDJS.
kamilogorek
pushed a commit
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our conversation on IRC, a PR for CommonJS/browserify support. 🍻
#259
#253
#206