Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserify support #253

Merged
merged 1 commit into from
Sep 3, 2014
Merged

browserify support #253

merged 1 commit into from
Sep 3, 2014

Conversation

hugomrdias
Copy link
Contributor

In a browserify package, this will refer to a node-style exports object, not
window. So just reference window directly.

…ct, not

window. So just reference window directly.
@hugomrdias
Copy link
Contributor Author

would be nice to remove private = true from package.json

@mattrobenolt
Copy link
Contributor

😕 If this is all it takes to make browserify happy, sure.

There was already https://www.npmjs.org/package/raven-js on npm. Is that a thing that should be maintained? Do things use npm to install this? Literally no idea how JavaScript works anymore.

@hugomrdias
Copy link
Contributor Author

yeah i saw that package, with this PR raven will work with npm and since this repo is the official one we could ask nicely for that package to be removed.

and yes ppl use npm to install raven especially with more and more ppl using browserify and commonjs to build client side apps. instead of using bower and npm we can just use npm for everything.

removing private = true would be nice even without having the repo submitted to the npm registry, since we can use github urls directly to install raven.

@okonet
Copy link

okonet commented Sep 3, 2014

Related to #257

@okonet okonet mentioned this pull request Sep 3, 2014
mattrobenolt added a commit that referenced this pull request Sep 3, 2014
@mattrobenolt mattrobenolt merged commit 35d36ab into getsentry:master Sep 3, 2014
@mattrobenolt
Copy link
Contributor

image

@hugomrdias
Copy link
Contributor Author

@mattrobenolt can you commit the dist files pls ?

@mattrobenolt
Copy link
Contributor

@hugomrdias I can cut a new release later.

@wheresrhys
Copy link

@mattrobenolt Could you please do a 1.1.17 release with this fix in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants