-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browserify support #253
browserify support #253
Conversation
…ct, not window. So just reference window directly.
would be nice to remove |
😕 If this is all it takes to make browserify happy, sure. There was already https://www.npmjs.org/package/raven-js on npm. Is that a thing that should be maintained? Do things use npm to install this? Literally no idea how JavaScript works anymore. |
yeah i saw that package, with this PR raven will work with npm and since this repo is the official one we could ask nicely for that package to be removed. and yes ppl use npm to install raven especially with more and more ppl using browserify and commonjs to build client side apps. instead of using bower and npm we can just use npm for everything. removing private = true would be nice even without having the repo submitted to the npm registry, since we can use github urls directly to install raven. |
Related to #257 |
@mattrobenolt can you commit the dist files pls ? |
@hugomrdias I can cut a new release later. |
@mattrobenolt Could you please do a 1.1.17 release with this fix in it. |
In a browserify package, this will refer to a node-style exports object, not
window. So just reference window directly.