Only log to console.error when Raven.debug is true #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To maintain existing behavior, I'd prefer then to have Then we can change this behavior with a larger version bump and mention it in the changelog. How does that sound? |
|
Sure works for me |
|
Thanks! 🍰 |
mattrobenolt
added a commit
that referenced
this pull request
Jul 16, 2014
Only log to console.error when Raven.debug is true
kamilogorek
pushed a commit
that referenced
this pull request
Jun 12, 2018
* Version 1.0.0-beta.0 * Make version validity regex understand beta version naming scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use Raven in production regardless of it being configured or not, without worrying about logging unnecessary errors to the console. Useful when Raven is only configured for a certain percentage of sessions to reduce the number of errors sent to sentry.
If debugging is required, just set Raven.debug = true.