Update raven.js to work around IE8 shortcomings #179
Conversation
Internet Explorer 8 chokes on an undefined or null reference passed into this function. Wrapping an if statement around the processing correctly handles this while still performing correctly.
| patterns[i].replace(/([.*+?^=!:${}()|\[\]\/\\])/g, "\\$1") : | ||
| // If it's a regexp already, we want to extract the source | ||
| patterns[i].source; | ||
| if (typeof patterns[i] != "undefined" && patterns[i]) { |
There was a problem hiding this comment.
I have a helper for isUndefined.
|
Looks good to me. Are you able to add a test to assert this behavior is correct and we don't regress in the future? |
Raven throws an error if empty or undefined variables are processed by joinRegExp. Some browsers (such as Internet Explorer 8 and possibly earlier) apparently pass these variables, causing errors.
|
Take a look at that and see if it's acceptable. |
|
So if we're being specific to the problem here, the issue is that it has a variable which doesn't have a source property. What if we did a check for: Thinking to prevent other edge cases that may pop up. I think this function can just be reworked to handle specifically if it's a string, or if it has a .source. Ignore everything else. Thoughts? |
Update raven.js to work around IE8 shortcomings
|
A buddy and I were working on a slightly more robust solution. Expect to see it soon! |
…rors in joinRegExp)
This slightly more robust solution ignores options that are not strings
or regular expressions in the passed patterns array.
The prior solution still accepted non-string, non-regexp options (e.g.
[], {}, true, etc.).
Credit goes to @soundslocke for the fix.
Improved solution to issue #179 (invalid options throwing errors in joinRegExp)
|
@johnbacon I've published a 1.1.8, fwiw with this patch. Thanks again. :) |
Internet Explorer 8 chokes on an undefined or null reference passed into the joinRegExp function:
Line 1762, character 9 is as follows:
Checking for the presence of an undefined or null value correctly handles this quirk while still seemingly performing correctly when present.