From 5eb11442c604fc56bed432a457458159feb93aba Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Thu, 12 Dec 2024 17:34:20 +0200 Subject: [PATCH 1/3] Return when the sendFeedback promise resolves --- packages/feedback/src/core/sendFeedback.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/feedback/src/core/sendFeedback.ts b/packages/feedback/src/core/sendFeedback.ts index 8342a03a2f71..a6d5b27163cf 100644 --- a/packages/feedback/src/core/sendFeedback.ts +++ b/packages/feedback/src/core/sendFeedback.ts @@ -52,7 +52,7 @@ export const sendFeedback: SendFeedback = ( response.statusCode >= 200 && response.statusCode < 300 ) { - resolve(eventId); + return resolve(eventId); } if (response && typeof response.statusCode === 'number' && response.statusCode === 0) { From 7dfcbb4d23e317fe78f2a3dbec741274bd8a78df Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Thu, 12 Dec 2024 17:44:16 +0200 Subject: [PATCH 2/3] Adds changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b3c6d567c0e..7b728276dcf0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ ## Unreleased +### Other Changes + +- fix(feedback): return when the sendFeedback promise resolves ([#14683](https://github.com/getsentry/sentry-javascript/pull/14683)) + - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott Work in this release was contributed by @anonrig. Thank you for your contribution! From 30efbb49d7dfb8a422daad6dbee190f22554b47b Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Thu, 12 Dec 2024 15:58:09 +0000 Subject: [PATCH 3/3] rm changelog entry --- CHANGELOG.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7b728276dcf0..0b3c6d567c0e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,10 +8,6 @@ ## Unreleased -### Other Changes - -- fix(feedback): return when the sendFeedback promise resolves ([#14683](https://github.com/getsentry/sentry-javascript/pull/14683)) - - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott Work in this release was contributed by @anonrig. Thank you for your contribution!