Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Replay] Align Replay event metadata #6366

Closed
2 of 3 tasks
Tracked by #6459
Lms24 opened this issue Dec 1, 2022 · 2 comments · Fixed by #6814
Closed
2 of 3 tasks
Tracked by #6459

[Replay] Align Replay event metadata #6366

Lms24 opened this issue Dec 1, 2022 · 2 comments · Fixed by #6814
Assignees
@Lms24
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Dec 1, 2022 •
edited
Loading

Replay Event metadata currently overwrites the SDK's name and version for replay events. We should align the metadata now that we migrated into the monorepo.

ref #5326
@Lms24 Lms24 mentioned this issue Dec 1, 2022
Closed
8 tasks
@Lms24 Lms24 self-assigned this Dec 1, 2022
@Lms24 Lms24 added the Package: replay Issues related to the Sentry Replay SDK label Dec 1, 2022
@Lms24 Lms24 mentioned this issue Dec 1, 2022
Merged
@Lms24
Copy link
Member Author

Lms24 commented Dec 2, 2022 •
edited
Loading

Setting this back to ToDo, as we're holding off from making these changes for the time being. Priority is low for this one.

@Lms24 Lms24 changed the title Align Replay event metadata [Replay] Align Replay event metadata Dec 2, 2022
This was referenced Dec 7, 2022
Closed
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@Lms24 Lms24 mentioned this issue Jan 16, 2023
Merged
@Lms24 Lms24 mentioned this issue Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lms24 Lms24

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(replay): Send SDK version in Replay events getsentry/sentry-javascript
1 participant
@Lms24