-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ember): Fix Ember to work with Embroider and Fastboot #3181
Conversation
This removes the ember-get-config dependency and opts to use Embroiders macros instead to have backwards and forwards compatibility.
e207b88
to
0ba7163
Compare
size-limit report
|
Lint and tests are failing (due to linting issue i guess). |
@kamilogorek yeah left a line in by accident, 👍 |
Hmm, this breaks in my app now? Does this require a different configuration? After looking through this change, it appears I have to set the config now in ember-cli-build.js like this:
is that correct? If so, this is not reflected in any changelog or the readme so far :) |
cc @k-fish |
@mydea thanks for bringing it up 👍 . You definitely shouldn't have to use |
Summary
This removes the ember-get-config dependency and opts to use Embroiders macros instead to have backwards and forwards compatibility.
Should fix #3174.
Other