-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of sessionStorage
in browserSessionIntegration
to more accurately count sessions for MPAs
#14478
Comments
Strawman proposal: We add a interface SessionIntegrationOptions {
/**
* The storage type that the SDK uses to store a Session ID that is used for Sessions and Release Health in Sentry.
*
* Possible values:
*
* - `"sessionStorage"` (default) The Session ID is persisted to the browser's `sessionStorage`. Sessions will persist across hard-navigations on the same origin.
* - `"memory"` The Session ID is stored in memory. Hard-navigations will produce new sessions.
*
* Defaults to `"sessionStorage"`.
*/
persistence?: 'sessionStorage' | 'memory'
} The |
Just wanted to mention I think this is a solid plan. Defaulting to Session Replay relies on A bigger question would be relying on |
+1 on making it opt-out in other words, makeing |
This has made another round among stakeholders, we will have to make the usage of |
browserSessionIntegration
to more accurately count sessions for MPAs
browserSessionIntegration
to more accurately count sessions for MPAssessionStorage
in browserSessionIntegration
to more accurately count sessions for MPAs
Description
Session updates we send from the Browser SDK are currently per pageview, leading to more sessions than is commonly understood for MPAs. We find that Sessions likely should have the same lifetime as a Session Replay session. For this we should introduce an option in the
browserSessionIntegration
that allows a user to configure a persistence model usingsessionStorage
to more accurately collect number of sessions.The text was updated successfully, but these errors were encountered: