Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning if if source-map generation would change with v9 #14286

Closed
7 tasks done
lforst opened this issue Nov 14, 2024 · 1 comment · Fixed by #14533
Closed
7 tasks done

Log warning if if source-map generation would change with v9 #14286

lforst opened this issue Nov 14, 2024 · 1 comment · Fixed by #14533
Assignees
Milestone

Comments

@lforst
Copy link
Member

lforst commented Nov 14, 2024

Description

As pre-work to #13993, we should go in and log warnings if source map generation behaviour will change when we implement this issue in v9.

Potential log messages:

  • "You disabled sourcemaps in your ... app with the ... option. Currently, the Sentry SDK will override this option to generate sourcemaps. In future versions, the Sentry SDK will not override the ... option if you explicitly disable it. If you want to generate and upload sourcemaps please set the ... option to true or undefined."
  • "The Sentry SDK has enabled source map generation. If you do not want to serve Source Maps to your users either set the deleteSourceMapsAfterUpload option to true, or manually delete the source maps after the build. In future Sentry SDK versions deleteSourceMapsAfterUpload will default to true."

SDKs

Copy link
Contributor

github-actions bot commented Dec 2, 2024

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14533, which was included in the 8.42.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant