-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hoist @sentry/types
into @sentry/core
#14271
Milestone
Comments
I don't understand this statement.
|
@timfish this decision was pushed by @mydea. The idea is to limit breakage.
The theory is that too many people depend on the types package through docs and similar. |
Oh ok, I was missing this bit of context! |
This was referenced Nov 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
We found that moving
@sentry/types
into@sentry/core
would clean up some architecture, docs, and prevent footguns like diverging package versions.This task involves:
@sentry/types
into@sentry/core
and exporting everything that was exported from types also from core (this also means we don't have to depend on@sentry/types
in@sentry/core
)@sentry/core
@sentry/types
from docs and replace with@sentry/core
@sentry/types
ATTENTION: Because of #9840 which is also planned for v9, we do not want to export the
Client
type from@sentry/core
. The same goes for theScope
type. Instead, we want to exportClient
as an alias forBaseClient
as part of this task, and theScope
interface as we have it in@sentry/types
should not make it into@sentry/core
.We don't want to delete
@sentry/types
in the v9 major, just deprecate. The friction for deletion would likely be too high.The text was updated successfully, but these errors were encountered: