Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raven-node] Domain Module Deprecated #1372

Closed
HazAT opened this issue Jun 12, 2018 · 5 comments
Closed

[raven-node] Domain Module Deprecated #1372

HazAT opened this issue Jun 12, 2018 · 5 comments

Comments

@HazAT
Copy link
Member

HazAT commented Jun 12, 2018

ref: getsentry/raven-node#264

@kamilogorek
Copy link
Contributor

kamilogorek commented Sep 4, 2018

We'll stick with domain in new SDK as well, as they are not going away soon.

@jdrydn
Copy link

jdrydn commented Mar 6, 2019

What if the context was portable?

[We] are working on making this happen soon, in the next major release.

@kamilogorek I thought the new Sentry for Node was going to move to some sort of portable context, so we didn't have to use domains if we didn't want to?

@kamilogorek
Copy link
Contributor

@jdrydn we provide all the necessary tools for anyone to make it happen if they are not willing to use domains. domain is used only when requestHandler is attached (eg. in express app)

to some sort of portable context, so we didn't have to use domains if we didn't want to

There's hub and scope for handling the context, which can be used to achieve literally anything end-user needs when it comes to custom event data:

Let me know if you have any specific questions and I can definitely help you with them.

@jdrydn
Copy link

jdrydn commented Oct 31, 2020

@kamilogorek Just came across passing context directly in the Sentry docs, which (pretty much) solves all my problems! I'll be deprecating my Vedette library as soon as I've rotated it out of production 🚀

@kamilogorek
Copy link
Contributor

@jdrydn

Vedette: A mounted sentry positioned beyond an army's outposts to observe the movements of the enemy.

Love the name! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants