Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Passing undefined to SDK init options should behave like not setting the options #13262

Open
Lms24 opened this issue Aug 7, 2024 · 1 comment
Milestone

Comments

@Lms24
Copy link
Member

Lms24 commented Aug 7, 2024

Description

Currently, we SDK behaviour differs (slightly) if we in higher level SDKs or users in general pass undefined to certain SDK init options instead of not setting them at all.

Examples:

Ideally, we just call dropUndefinedKeys on the user-passed options and move on. However, for this to work we need to change the implementation of hasTracingEnabled to not differentiate between the two possibilities. Also this questions the validity of hasTracingEnabled entirely because even if no sample rates are set at all, "Tracing without Performance" should be enabled.

@Lms24
Copy link
Member Author

Lms24 commented Aug 7, 2024

The good news is that this seems mostly to be a browser issue as the Node SDK handles user option merging a bit differently.

@Lms24 Lms24 added this to the 9.0.0 milestone Sep 23, 2024
@lforst lforst removed this from the 9.0.0 milestone Nov 13, 2024
@lforst lforst changed the title Passing undefined to SDK init options should behave like not setting the options [v9] Passing undefined to SDK init options should behave like not setting the options Nov 13, 2024
@lforst lforst added this to the 9.0.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants