Merge pull request #229 from zaizhuang/debugging

Only log to console.error when Raven.debug is true
getsentry · Jul 16, 2014 · fcad13a · fcad13a
2 parents 116e12a + 173ae2c
commit fcad13a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/raven.js b/src/raven.js
@@ -31,6 +31,8 @@ var _Raven = window.Raven,
 var Raven = {
     VERSION: '<%= pkg.version %>',
 
+    debug: true,
+
     /*
      * Allow multiple versions of Raven to be installed.
      * Strip Raven from the global context and returns the instance.
@@ -679,7 +681,7 @@ function makeRequest(data) {
 function isSetup() {
     if (!hasJSON) return false;  // needs JSON support
     if (!globalServer) {
-        if (window.console && console.error) {
+        if (window.console && console.error && Raven.debug) {
             console.error("Error: Raven has not been configured.");
         }
         return false;

diff --git a/test/raven.test.js b/test/raven.test.js
@@ -215,11 +215,27 @@ describe('globals', function() {
             assert.isFalse(isSetup());
         });
 
-        it('should return false when Raven is not configured and write to console.error', function() {
+        it('should return false when Raven is not configured', function() {
             hasJSON = true;    // be explicit
             globalServer = undefined;
             this.sinon.stub(console, 'error');
             assert.isFalse(isSetup());
+        });
+
+        it('should not write to console.error when Raven is not configured and Raven.debug is false', function() {
+            hasJSON = true;    // be explicit
+            globalServer = undefined;
+            Raven.debug = false;
+            this.sinon.stub(console, 'error');
+            isSetup();
+            assert.isFalse(console.error.calledOnce);
+        });
+
+        it('should write to console.error when Raven is not configured and Raven.debug is true', function() {
+            hasJSON = true;    // be explicit
+            globalServer = undefined;
+            this.sinon.stub(console, 'error');
+            isSetup();
             assert.isTrue(console.error.calledOnce);
         });