From d9d3b06832a9c6a151487b38e98cd67067cd36b6 Mon Sep 17 00:00:00 2001 From: Andrei <168741329+andreiborza@users.noreply.github.com> Date: Thu, 12 Dec 2024 14:43:31 +0100 Subject: [PATCH] fix(aws-serverless): Remove v8 layer as it overwrites the current layer for docs (#14679) Unfortunately, having the v8 layer already in `.craft.yml` ends up with this layer being the default selection in the docs. ![Screenshot 2024-12-12 at 13 02 08@2x](https://github.com/user-attachments/assets/30bb83ce-79e9-41b1-887b-ec4ab7019a10) We should add this to the `v8` branch once it exists instead. --- .craft.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.craft.yml b/.craft.yml index b5646547f113..44d245311312 100644 --- a/.craft.yml +++ b/.craft.yml @@ -142,10 +142,12 @@ targets: id: '@sentry-internal/eslint-config-sdk' includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/ - # AWS Lambda Layer target + # TODO(v9): Remove this target + # NOTE: We publish the v8 layer under its own name so people on v8 can still get patches + # whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer. - name: aws-lambda-layer includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/ - layerName: SentryNodeServerlessSDK + layerName: SentryNodeServerlessSDKv8 compatibleRuntimes: - name: node versions: @@ -157,13 +159,10 @@ targets: - nodejs20.x license: MIT - # NOTE: We publish the v8 layer under its own name so people on v8 can still get patches - # whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer. - # AWS Lambda Layer target - name: aws-lambda-layer includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/ - layerName: SentryNodeServerlessSDKv8 + layerName: SentryNodeServerlessSDK compatibleRuntimes: - name: node versions: