From 51577b8574bad27cd62f5740997d6d8f5b2604da Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Wed, 4 Aug 2021 11:52:13 -0700 Subject: [PATCH] add links to comment --- packages/utils/src/object.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/utils/src/object.ts b/packages/utils/src/object.ts index 9c901fc446fe..c06ea5877ddc 100644 --- a/packages/utils/src/object.ts +++ b/packages/utils/src/object.ts @@ -108,9 +108,11 @@ function getWalkSource( [key: string]: any; } = {}; + // Accessing event attributes can throw (see https://github.com/getsentry/sentry-javascript/issues/768 and + // https://github.com/getsentry/sentry-javascript/issues/838), but accessing `type` hasn't been wrapped in a + // try-catch in at least two years and no one's complained, so that's likely not an issue anymore source.type = event.type; - // Accessing event.target can throw (see getsentry/raven-js#838, #768) try { source.target = isElement(event.target) ? htmlTreeAsString(event.target)