add in environment option (#179)

getsentry · Jul 29, 2016 · 14401a2 · 14401a2
1 parent c1035b5
commit 14401a2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -41,6 +41,7 @@ var Client = function Client(dsn, options) {
   this.root = options.root || process.cwd();
   this.transport = options.transport || transports[this.dsn.protocol];
   this.release = options.release || process.env.SENTRY_RELEASE || '';
+  this.environment = options.environment || process.env.SENTRY_ENVIRONMENT || '';
 
   this.loggerName = options.logger || '';
   this.dataCallback = options.dataCallback;

diff --git a/test/raven.client.js b/test/raven.client.js
@@ -127,6 +127,20 @@ describe('raven.Client', function() {
     delete process.env.SENTRY_RELEASE;
   });
 
+  it('should pull environment from options if present', function() {
+    var client = new raven.Client(dsn, {
+      environment: 'staging'
+    });
+    client.environment.should.eql('staging');
+  });
+
+  it('should pull SENTRY_ENVIRONMENT from environment', function() {
+    process.env.SENTRY_ENVIRONMENT = 'staging';
+    var client = new raven.Client(dsn);
+    client.environment.should.eql('staging');
+    delete process.env.SENTRY_ENVIRONMENT;
+  });
+
   describe('#getIdent()', function() {
     it('should match', function() {
       var result = {