Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically turn on source maps generation #256

Open
lforst opened this issue May 23, 2023 · 5 comments
Open

Automatically turn on source maps generation #256

lforst opened this issue May 23, 2023 · 5 comments

Comments

@lforst
Copy link
Member

lforst commented May 23, 2023

  • How to do safely so we don't end up publishing user code by accident?
  • Maybe just add some warnings + instructions?
  • Auto remove source maps after upload?
@HazAT
Copy link
Member

HazAT commented May 23, 2023

I think if someone goes as far and adds the plugin - they want source maps.

For those people where the wizard adds it - it's also fine.
This is not an issue and we don't need to be overly careful with it.

The countet argument is, without source maps - Sentry is more or less useless.

@lforst
Copy link
Member Author

lforst commented May 23, 2023

I want to be careful especially with the move towards Next.js server actions and all. We could be publishing serverside source code that contains secrets. But yea I wanna do this too.

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@timfish
Copy link
Collaborator

timfish commented Jul 2, 2023

  • Auto remove source maps after upload?

I think this would be key. If you force enable source maps, they should not end up in the output.

I've seen production Electron apps that have shipped source maps and this is almost always unintentional!

@s1gr1d
Copy link
Member

s1gr1d commented Dec 10, 2024

Related to this issue: getsentry/sentry-javascript#13993

If no source map settings are set, we will enable 'hidden' source maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants