Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to remove TempSensorBreadcrumbsIntegration (in new versions), causing app *rejected* by app stores #2821

Closed
fzyzcjy opened this issue Jul 6, 2023 · 2 comments · Fixed by #2826
Assignees

Comments

@fzyzcjy
Copy link

fzyzcjy commented Jul 6, 2023

Integration

sentry-android

Build System

Gradle

AGP Version

latest

Proguard

Enabled

Version

latest

Steps to Reproduce

Last time I submitted #2355 which caused apps rejected by stores, the solution was to do something like:

SentryAndroid.init(context) { options ->
  options.integrations.removeAll { it is TempSensorBreadcrumbsIntegration }
}

However, that does not work after I upgrade Sentry. Indeed, that issue was solved at 2022.11.14, while the code that breaks the solution was created at 2022.11.18 (what a short time!) at #2377.

As you can see, with that PR, the configure callback is executed before the TempSensorBreadcrumbsIntegration has a chance to be added to the integrations.

configuration.configure(options);
AndroidOptionsInitializer.initializeIntegrationsAndProcessors(

Therefore, I would appreciate it if this could be fixed. For example, we can add something similar to isEnableSystemEventBreadcrumbs, but specific to temperature sensor.

Expected Result

Actual Result

@fzyzcjy fzyzcjy added Platform: Android Type: Bug Something isn't working labels Jul 6, 2023
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jul 6, 2023
@fzyzcjy fzyzcjy changed the title No way to removeTempSensorBreadcrumbsIntegration (in new versions), causing app rejected by stores No way to remove TempSensorBreadcrumbsIntegration (in new versions), causing app rejected by stores Jul 6, 2023
@fzyzcjy fzyzcjy changed the title No way to remove TempSensorBreadcrumbsIntegration (in new versions), causing app rejected by stores No way to remove TempSensorBreadcrumbsIntegration (in new versions), causing app *rejected* by app stores Jul 6, 2023
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Jul 6, 2023
@stefanosiano stefanosiano self-assigned this Jul 6, 2023
@kahest kahest moved this from Needs Discussion to In Progress in Mobile & Cross Platform SDK Jul 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK Jul 11, 2023
@stefanosiano
Copy link
Member

Hey @fzyzcjy this issue was fixed in the release 6.25.1.
Feel free to reopen this issue in case something goes wrong

@fzyzcjy
Copy link
Author

fzyzcjy commented Jul 12, 2023

Thank you, it looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants