-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending from offline caching should be scheduled #803
Labels
Feature
New feature or request
Comments
Relates to getsentry/sentry-java#912 and getsentry/sentry-cocoa#316 |
This was referenced Jul 21, 2021
Closed
SimonCropp
moved this from Needs Discussion
to Needs Investigation
in Mobile & Cross Platform SDK
Jun 29, 2022
we think this is already done. @mattjohnsonpint will investigate |
Yes, this was fixed in #1644 |
Repository owner
moved this from Needs Investigation
to Done
in Mobile & Cross Platform SDK
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On startup we try to submit cached files. But that's done on the calling thread up to the specified timeout. The goal was to block the calling thread for up to a sensible default, in order to send 1 crash in case the app has a bug that causes it to crash right after starting.
But this blocking of
Init
to send the event doesn't mean that the calling thread should be use to send the event. In fact, during Init, sending cached events should be scheduled on a background thread, and if the timeout of waiting on Init elapses, Init should return but the background thread should continue to do its job and flush out queued events.Even if
InitCacheFlushTimeout
is set to 0, the SDK should then simply schedule flushing these events to Sentry onInit
, just not block at all on theTask
. This way we don't need to rely on new events happening to capture cached events on app restart.Docs will need to be updated: https://docs.sentry.io/platforms/dotnet/configuration/options/
i.e:
The text was updated successfully, but these errors were encountered: