New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP.NET Core performance integration should bind Transaction automatically to scope #760

Closed

Tyrrrz opened this issue Jan 23, 2021 · 1 comment · Fixed by #766

Labels

Bug Framework: ASP.NET Core

Contributor

Tyrrrz commented Jan 23, 2021

Currently, there is no way to access the transaction that was created by the middleware.

Tyrrrz added Bug Framework: ASP.NET Core Sentry labels

Contributor

kanadaj commented Jan 23, 2021 •

edited by Tyrrrz

Loading

Things needed:

Bind the transaction in the middleware on creation
A GetCurrentTransaction() on IHub or ISentryClient
Possibly a StartSpan() helper method to avoid fiddling with the transaction
Either make CaptureTransaction() internal, or change the parameter type to ITransaction for consistency with public APIs.

Tyrrrz mentioned this issue

Improve transaction instrumentation on ASP.NET Core #766

Merged

bruno-garcia closed this as completed in #766

bruno-garcia added the Platform: .NET label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment