Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate all .NET Framework installations #531

Closed
bruno-garcia opened this issue Sep 27, 2020 · 2 comments · Fixed by #572
Closed

Enumerate all .NET Framework installations #531

bruno-garcia opened this issue Sep 27, 2020 · 2 comments · Fixed by #572

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Sep 27, 2020

PlatformAbstractions API is able to enumerate all .NET Framework installations.
An integration could be created to do so on .NET Framework.
The data would fit on a Context called .NET Framework

Basically: NetFrameworkInstallIntegration class that implement ISdkIntegration
and it'll call hub.AddEventProcessor(s => s.Contexts[".NET Framework"] = GetInstallations()
this method GetInstallations will returns an object that lists all installations.

The integration could be added by default on #if NET461 but there should be a way to opt-out (like options.RemoveIntegration<NetFrameworkInstallIntegration>();

@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented Nov 4, 2020

@bruno-garcia IHub doesn't implement AddEventProcessor (but since Register exposes SentryOptions you would be able to add the EventProcessor on it).
Also, as far as I know, options.RemoveIntegration<NetFrameworkInstallIntegration>(); wouldn't stop the events to get attached with the .NET List.

Lastly, I feel this feature could be sorted with an event processor (as showed on PR), but I can rollback to the SdkIntegration solution.

@bruno-garcia
Copy link
Member Author

Also, as far as I know, options.RemoveIntegration(); wouldn't stop the events to get attached with the .NET List.

What do you mean by the event getting attached to .NET List?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants