ISentryUserFactory doesn't work unless it also implements the obsolete IUserFactory interface

[ian-a-anderson]

Package

Sentry.AspNetCore

.NET Flavor

.NET

.NET Version

6.0.0

OS

Linux

SDK Version

3.40.1

Self-Hosted Sentry Version

No response

Steps to Reproduce

1. Sentry currently warns against using IUserFactory and recommends users switch to ISentryUserFactory:

2. However, if you only implement and register ISentryUserFactory your custom code is never hit, because Sentry itself only looks for the obsolete IUserFactory implementation:
   

   sentry-dotnet/src/Sentry.AspNetCore/ScopeExtensions.cs

   Line 42 in 343d921

   var userFactory = context.RequestServices.GetService<IUserFactory>();

Expected Result

Implementing and registering ISentryUserFactory should work without having to continue implementing the obsolete IUserFactory interface.

Actual Result

No custom user code is hit when running with only a ISentryUserFactory implementation registered.

In order to allow users to transition away from IUserFactory, the underlying code in ScopeExtensions should look for implementations of ISentryUserFactory and reference them if registered.

[bitsandfoxes]

Thanks for raising this @ian-a-anderson. A fix is on its way.

[ian-a-anderson]

Thanks for raising this @ian-a-anderson. A fix is on its way.
Just to confirm, is the fix coming in the v3.40 codebase or only with v4?

[vaind]

Thanks for raising this @ian-a-anderson. A fix is on its way.
Just to confirm, is the fix coming in the v3.40 codebase or only with v4?

v4.0.0 - #2840