-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum .NET Framework target to 4.6.2. #1666
Comments
Looks like it still is being built for netstandard2.0, so net461 should still work - no? |
officially yes. in reality no
the caveat is here https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version
|
Given that Microsoft recently ended support for .NET Framework 4.6.1 on April 26, 2022, I would be ok bumping that to 4.6.2 at the same time we add a |
Thinking this through more over time, I think we need to keep the https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king Since we would still be offering a Also, it doesn't do much for us really. As long as we have to build for As for the STJ concern, this is the only place we take a hard dependency. sentry-dotnet/src/Sentry/Sentry.csproj Lines 60 to 63 in 7260dff
So .NET Framework and .NET Standard targets will use a minimum STJ of 5.0.2, which won't change unless there's a big problem, such as a security vulnerability. Applications can install a newer STJ if they want or need to. Most newer targets (.NET Core 3.0+) will by default get the version of STJ bundled with the runtime (6.x for .NET 6, 7.x for .NET 7, etc.). Thus there's nothing special we need to do for continued STJ support across all our targets. If in the future we find that one of our dependencies dropped NET461 and that became an issue, we could always pin NET461 to the dependencies last working version and create a separate NET462 target. But that's not warranted at this time. Thanks. |
so v7 of System.Text.Json drops support for net461 https://www.nuget.org/packages/System.Text.Json/7.0.0-preview.4.22229.4
So i assume we need to change the min target to 462?
The text was updated successfully, but these errors were encountered: