-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCS) Document Custom Performance Metrics #5257
Comments
Routing to @getsentry/team-web-sdk-frontend for triage. ⏲️ |
As per https://develop.sentry.dev/sdk/event-payloads/transaction/ Do we need to differentiate between built-in measurements and custom measurements? Do we mention the limit we have on custom measurements?
Units: https://getsentry.github.io/relay/relay_metrics/enum.MetricUnit.html |
Yes, the difference should be explained. I will update checklist item 2
Yes we can mention it, but this limit is not set in the SDK if memory serves well. So I would lean towards stating something along the lines of "there is a server side limit, initially set to X (i think it's 20 or 5?)" and not really a need to get more detailed than that |
where do we think these belong in docs? Under enriching events? https://docs.sentry.io/platforms/javascript/enriching-events/ |
These are part of performance monitoring, so I would say https://docs.sentry.io/platforms/javascript/performance/ or similar. Think it should be under the instrumentation section: https://docs.sentry.io/platforms/javascript/performance/instrumentation/ |
Intro:
Developers wishing to collect custom performance metrics,
will need some documentation explaining how to use it and some example implementation,
so that they can send these metrics to Sentry and visualize them in product
Checklist:
setMeasurements
public setMeasurement(name: string, value: number, unit: MeasurementUnit = ''): void { this._measurements[name] = { value, unit };
Related:
setMeasurement
public API sentry-javascript#4933follow up
The text was updated successfully, but these errors were encountered: