Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Starfish] Add db attributes to database span's span data #1594

Closed
Tracked by #19
AbhiPrasad opened this issue Aug 9, 2023 · 2 comments · Fixed by #1629
Closed
Tracked by #19

[Starfish] Add db attributes to database span's span data #1594

AbhiPrasad opened this issue Aug 9, 2023 · 2 comments · Fixed by #1629

Comments

@AbhiPrasad
Copy link
Member

To get an overview of this work across all SDKs, please visit:
https://github.com/orgs/getsentry/projects/135

Parent issue: getsentry/team-sdks#19

For the starfish db module it was determined that we need extra database attributes.

db.name should be set if possible, but is not required. db.system should match the list in OpenTelemetry's well known conventions.

Attribute Type Description Examples Requirement Level
db.system string An identifier for the database management system (DBMS) product being used. sqlite Required
db.name string This attribute is used to report the name of the database being accessed. For commands that switch the database, this should be set to the target database (even if the command fails). customers; main Conditionally Required: If applicable.

These values should be set on span.data.

Motivation

This is being done for the Sentry's new performance views for databases. See a WIP example of the view below:

image
@buenaflor
Copy link
Contributor

Should these attributes also be set on spans for opening/closing db? or strictly only for queries

@AbhiPrasad
Copy link
Member Author

@buenaflor preferably only on the query span, but it's also fine to duplicate the attributes among all db related spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants