-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SIGABRT
when modifying scope user
#4274
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e84bc3f | 1201.49 ms | 1232.82 ms | 31.33 ms |
e072ad1 | 1232.43 ms | 1245.51 ms | 13.08 ms |
6c31077 | 1233.80 ms | 1245.34 ms | 11.54 ms |
e1cd9e9 | 1190.64 ms | 1221.90 ms | 31.26 ms |
25737cb | 1235.02 ms | 1250.06 ms | 15.04 ms |
c00eafe | 1198.26 ms | 1227.62 ms | 29.36 ms |
94e1968 | 1234.41 ms | 1252.63 ms | 18.22 ms |
a7ca2d1 | 1237.42 ms | 1248.98 ms | 11.56 ms |
cf724da | 1226.61 ms | 1235.70 ms | 9.09 ms |
881a955 | 1222.94 ms | 1246.26 ms | 23.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
e072ad1 | 21.58 KiB | 625.83 KiB | 604.24 KiB |
6c31077 | 22.84 KiB | 401.65 KiB | 378.81 KiB |
e1cd9e9 | 22.85 KiB | 412.95 KiB | 390.10 KiB |
25737cb | 20.76 KiB | 436.29 KiB | 415.53 KiB |
c00eafe | 20.76 KiB | 432.87 KiB | 412.11 KiB |
94e1968 | 21.58 KiB | 614.74 KiB | 593.15 KiB |
a7ca2d1 | 21.58 KiB | 614.92 KiB | 593.34 KiB |
cf724da | 20.76 KiB | 430.52 KiB | 409.76 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
Previous results on branch: fix/sigabrt-modify-scope-user
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d582094 | 1226.80 ms | 1235.85 ms | 9.06 ms |
fa19249 | 1218.38 ms | 1245.06 ms | 26.69 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d582094 | 21.58 KiB | 705.05 KiB | 683.47 KiB |
fa19249 | 21.58 KiB | 705.53 KiB | 683.95 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good, but I think the test needs to be a little more strict.
Tests/SentryTests/Integrations/SentryCrash/SentryCrashScopeObserverTests.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4274 +/- ##
=============================================
+ Coverage 91.580% 91.634% +0.054%
=============================================
Files 616 617 +1
Lines 50096 50194 +98
Branches 18015 18107 +92
=============================================
+ Hits 45878 45995 +117
+ Misses 4125 4106 -19
Partials 93 93
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Fix
SIGABRT
when modifying scope user💡 Motivation and Context
Closes #4231
💚 How did you test it?
Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.