-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose span baggage API #4207
Expose span baggage API #4207
Conversation
|
…y-cocoa into feat/expose-span-baggage # Conflicts: # Sources/Sentry/SentrySpan.m
…y-cocoa into feat/expose-span-baggage # Conflicts: # Sources/Sentry/SentrySpan.m
…y-cocoa into feat/expose-span-baggage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
=============================================
+ Coverage 91.601% 91.607% +0.006%
=============================================
Files 617 617
Lines 50045 50059 +14
Branches 18096 18106 +10
=============================================
+ Hits 45842 45858 +16
+ Misses 4110 4108 -2
Partials 93 93
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@denrase and @brustolin, what's stopping us from merging this? |
@philipphofmann Need to take another look if the failing CI is just flaky again or if it has to do with this PR. |
@denrase, please merge main back into this branch. I fixed many flaky tests last week. That could fix your problems. |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae1fe61 | 1231.81 ms | 1252.76 ms | 20.95 ms |
32ac934 | 1238.86 ms | 1243.37 ms | 4.52 ms |
98a8c16 | 1234.69 ms | 1265.02 ms | 30.33 ms |
5f8ee7a | 1253.96 ms | 1264.98 ms | 11.02 ms |
01a28a9 | 1225.55 ms | 1249.96 ms | 24.41 ms |
31208ed | 1217.45 ms | 1246.69 ms | 29.24 ms |
2719ce6 | 1211.75 ms | 1237.16 ms | 25.41 ms |
297f460 | 1234.81 ms | 1255.27 ms | 20.45 ms |
881a955 | 1230.98 ms | 1246.22 ms | 15.24 ms |
84fb4d9 | 1237.76 ms | 1255.46 ms | 17.70 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae1fe61 | 21.58 KiB | 698.91 KiB | 677.33 KiB |
32ac934 | 21.58 KiB | 616.72 KiB | 595.14 KiB |
98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
5f8ee7a | 22.85 KiB | 411.93 KiB | 389.08 KiB |
01a28a9 | 22.85 KiB | 405.39 KiB | 382.55 KiB |
31208ed | 20.76 KiB | 435.26 KiB | 414.50 KiB |
2719ce6 | 20.76 KiB | 435.13 KiB | 414.37 KiB |
297f460 | 21.58 KiB | 629.83 KiB | 608.24 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.79 KiB |
84fb4d9 | 22.84 KiB | 402.57 KiB | 379.72 KiB |
@philipphofmann The files were not properly prepared to be public, everything should be fixed now and we can merge. |
📜 Description
SentrySpanContext
andSentryBaggage
classesbaggageHttpHeader
andtraceContext
onSentrySpan
protocol💡 Motivation and Context
Closes #3519
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
Exposing
traceContext
inSentrySpanProtocol
makes it optional, also forSentryTracer
implementations. Could this be an issue?