Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pod lib lint work for Xcode 14.0.1 #2254

Closed
philipphofmann opened this issue Oct 4, 2022 · 4 comments
Closed

Make pod lib lint work for Xcode 14.0.1 #2254

philipphofmann opened this issue Oct 4, 2022 · 4 comments

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Oct 4, 2022

Description

Since October 3rd, the default Xcode version is 14.0.1 on GH actions macos-12, which breaks pod lib lint. With #2253 we stick to Xocde 13.4.1, but we should make make pod-lint work for Xcode 14.01.

Relevant logs

-> Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.
   Building with `xcodebuild`.
    $ /usr/bin/xcodebuild clean build -workspace
    /var/folders/hr/j34m30s91296zf7prcx227mw0000gn/T/com.apple.WorkflowKit.BackgroundShortcutRunner/CocoaPods-Lint-20221004-5253-1b0oyve-Sentry/App.xcworkspace
    -scheme App -configuration Release CODE_SIGN_IDENTITY=- -sdk watchsimulator -destination id=47C2E8A3-7DEE-4EAF-AF55-CA13C3D7DAE4
    Command line invocation:
        /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild clean build -workspace /var/folders/hr/j34m30s91296zf7prcx227mw0000gn/T/com.apple.WorkflowKit.BackgroundShortcutRunner/CocoaPods-Lint-20221004-5253-1b0oyve-Sentry/App.xcworkspace -scheme App -configuration Release CODE_SIGN_IDENTITY=- -sdk watchsimulator -destination id=47C2E8A3-7DEE-4EAF-AF55-CA13C3D7DAE4

    User defaults from command line:
        IDEPackageSupportUseBuiltinSCM = YES

    Build settings from command line:
        CODE_SIGN_IDENTITY = -
        SDKROOT = watchsimulator9.0

    2022-10-04 16:36:45.275 xcodebuild[11057:2497561] Writing error result bundle to /var/folders/hr/j34m30s91296zf7prcx227mw0000gn/T/com.apple.WorkflowKit.BackgroundShortcutRunner/ResultBundle_2022-04-10_16-36-0045.xcresult
    xcodebuild: error: Unable to find a destination matching the provided destination specifier:
    		{ id:47C2E8A3-7DEE-4EAF-AF55-CA13C3D7DAE4 }

    	The requested device could not be found because no available devices matched the request.

    	Available destinations for the "App" scheme:
    		{ platform:watchOS, id:dvtdevice-DVTiOSDevicePlaceholder-watchos:placeholder, name:Any watchOS Device }
    		{ platform:watchOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-watchsimulator:placeholder, name:Any watchOS Simulator Device }
    		{ platform:watchOS Simulator, id:47C2E8A3-7DEE-4EAF-AF55-CA13C3D7DAE4, OS:9.0, name:Apple Watch SE (44mm) (2nd generation) }
    		{ platform:watchOS Simulator, id:C0D941CD-D89C-44C5-8311-9063B0E15E94, OS:9.0, name:Apple Watch Series 5 (40mm) }
    		{ platform:watchOS Simulator, id:44023E3C-2092-4DB5-838E-FF96D9C7C73D, OS:9.0, name:Apple Watch Series 5 (44mm) }
    		{ platform:watchOS Simulator, id:3F7459FE-DF54-4150-8885-BCCF63178FD2, OS:9.0, name:Apple Watch Series 6 (40mm) }
    		{ platform:watchOS Simulator, id:E3CC409D-DC13-4730-A893-0653E8A7054E, OS:9.0, name:Apple Watch Series 6 (44mm) }
    		{ platform:watchOS Simulator, id:0D5BD605-D1DE-44D9-B0D5-79B4175CF2AD, OS:9.0, name:Apple Watch Series 7 (41mm) }
    		{ platform:watchOS Simulator, id:D0AC6074-11DD-42B2-A158-BE66B48F501A, OS:9.0, name:Apple Watch Series 7 (45mm) }
    		{ platform:watchOS Simulator, id:15750866-A1D2-4D92-BD44-0D07BDA3A76B, OS:9.0, name:Apple Watch Series 8 (41mm) }
    		{ platform:watchOS Simulator, id:23895883-E34D-48C3-BD97-0DFFFE778F5F, OS:9.0, name:Apple Watch Series 8 (45mm) }
    		{ platform:watchOS Simulator, id:93B8CC9F-E039-4922-926E-AF2556584968, OS:9.0, name:Apple Watch Ultra (49mm) }
    		{ platform:iOS Simulator, id:EF58CC57-7C99-4734-A625-160012B3422E, OS:16.0, name:iPhone 12 Pro Max }
    		{ platform:iOS Simulator, id:B7B501D6-C99E-41B8-8DE9-6AC2239E4185, OS:16.0, name:iPhone 13 }
    		{ platform:iOS Simulator, id:53C99D0F-AE5B-4E45-B587-E67F514D9BAE, OS:16.0, name:iPhone 13 Pro }
    		{ platform:iOS Simulator, id:D616F470-10B0-4BDF-BB7B-CACEE7BB64B0, OS:16.0, name:iPhone 13 Pro Max }
    		{ platform:iOS Simulator, id:E9090A6C-0A1F-491B-BD48-B38F9EF4CC62, OS:16.0, name:iPhone 13 mini }
    		{ platform:iOS Simulator, id:13117F1C-5EB1-40E3-8B01-F755A63C3F67, OS:16.0, name:iPhone 14 }
    		{ platform:iOS Simulator, id:26E0CA5A-D198-4FF0-B053-F5687E6AB9A1, OS:16.0, name:iPhone 14 Plus }
    		{ platform:iOS Simulator, id:6A3C2D6F-C297-458B-9125-370804261F79, OS:16.0, name:iPhone 14 Pro }
    		{ platform:iOS Simulator, id:B4227A5E-E7FC-4FCA-892D-18BE8FB20BE3, OS:16.0, name:iPhone 14 Pro Max }
   Testing with `xcodebuild`.
 -> Sentry (7.27.0)
    - NOTE  | [Sentry/Core] xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [Sentry/Core] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [Sentry/Core] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.0.99. (in target 'Sentry' from project 'Pods')
    - NOTE  | [Sentry/Core] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.0.99. (in target 'Pods-App' from project 'Pods')
    - NOTE  | [Sentry/Core] xcodebuild:  /var/folders/hr/j34m30s91296zf7prcx227mw0000gn/T/com.apple.WorkflowKit.BackgroundShortcutRunner/CocoaPods-Lint-20221004-5253-1b0oyve-Sentry/App.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.0.99. (in target 'App' from project 'App')
    - NOTE  | [Sentry/Core] xcodebuild:  note: Using codesigning identity override:
    - NOTE  | [Sentry/Core] xcodebuild:  Pods.xcodeproj: warning: The tvOS Simulator deployment target 'TVOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.0.99. (in target 'Sentry' from project 'Pods')
    - NOTE  | [Sentry/Core] xcodebuild:  Pods.xcodeproj: warning: The tvOS Simulator deployment target 'TVOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.0.99. (in target 'Pods-App' from project 'Pods')
    - NOTE  | [Sentry/Core] xcodebuild:  /var/folders/hr/j34m30s91296zf7prcx227mw0000gn/T/com.apple.WorkflowKit.BackgroundShortcutRunner/CocoaPods-Lint-20221004-5253-1b0oyve-Sentry/App.xcodeproj: warning: The tvOS Simulator deployment target 'TVOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.0.99. (in target 'App' from project 'App')
    - ERROR | [Sentry/Core] xcodebuild: Returned an unsuccessful exit code.
    - NOTE  | [Sentry/Core] xcodebuild:  xcodebuild: error: Unable to find a destination matching the provided destination specifier:

[!] Sentry did not pass validation, due to 1 error.
You can use the `--no-clean` option to inspect any issue.
@kevinrenskers
Copy link
Contributor

I think we can close #2245 that I created?

@philipphofmann
Copy link
Member Author

Related to CocoaPods/CocoaPods#11558

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@philipphofmann
Copy link
Member Author

philipphofmann commented Feb 28, 2024

pod lib lint runs with Xcode 14.3, which is the default of ci-select-xcode.sh.

lint-podspec:
name: pod lint ${{ matrix.podspec}} ${{ matrix.library_type }} ${{ matrix.platform}}
runs-on: macos-13
strategy:
matrix:
podspec: ['Sentry', 'SentrySwiftUI']
platform: ['ios', 'macos', 'tvos', 'watchos']
library_type: ['dynamic', 'static']
steps:
- uses: actions/checkout@v4
- run: ./scripts/ci-select-xcode.sh
# We need to update the spec-repo, because it can happen that it is not up to date and then the lint fails.
- run: pod repo update
- name: Validate Podspec
run: ./scripts/pod-lib-lint.sh ${{ matrix.platform }} ${{ matrix.podspec}} ${{ matrix.library_type}}

We can close this.

@philipphofmann philipphofmann closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Mobile & Cross Platform SDK Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants