feat(proguard): Introduce experimental chunk uploading feature #2264
+187
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-experimental-chunk-upload
branch
2 times, most recently
from
a5fc091
to
fa4adb8
Compare
loewenheim
approved these changes
Nov 22, 2024
Introduce an experimental chunk uploading feature for the `sentry-cli upload-proguard` command. The feature can be activated by setting the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to `1`. The feature is only activated when users opt in via this environment variable. The experimental chunk uploading feature is not backwards compatible. We attempt the upload regardless of whether the server supports receiving chunk-uploaded Proguard files. Server-side support will only be available once getsentry/sentry#81131 is released. The goal here was to create something that works, so some optimizations that we use for other chunk uploaded file types (e.g. first checking whether any chunks are present on the server, and only uploading the missing ones), are not implemented for Proguard. Ref #2196
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-experimental-chunk-upload
branch
from
fa4adb8
to
c8eab31
Compare
szokeasaurusrex
deleted the
szokeasaurusrex/proguard-experimental-chunk-upload
branch
szokeasaurusrex
added a commit
to getsentry/sentry-android-gradle-plugin
that referenced
this pull request
Nov 22, 2024
Bump `sentry-cli` to `2.39.0`. This version includes an experimental chunk uploading feature for Proguard files: getsentry/sentry-cli#2264.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an experimental chunk uploading feature for the
sentry-cli upload-proguardcommand. The feature can be activated by setting theSENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOADenvironment variable to1. The feature is only activated when users opt in via this environment variable.The experimental chunk uploading feature is not backwards compatible. We attempt the upload regardless of whether the server supports receiving chunk-uploaded Proguard files. Server-side support will only be available once getsentry/sentry#81131 is released. The goal here was to create something that works, so some optimizations that we use for other chunk uploaded file types (e.g. first checking whether any chunks are present on the server, and only uploading the missing ones), are not implemented for Proguard.
Ref #2196