Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script is failing for Python3 #706

Closed
ChillarAnand opened this issue Oct 18, 2020 · 3 comments
Closed

Install script is failing for Python3 #706

ChillarAnand opened this issue Oct 18, 2020 · 3 comments

Comments

@ChillarAnand
Copy link

Version Information

Version: latest master

Description

Looks like there is some byte/str conversion issue while upgrading.

Steps to Reproduce


    $ git pull origin master
    
    $ docker-compose build snuba-cleanup cron web symbolicator-cleanup ingest-consumer worker post-process-forwarder sentry-cleanup

    $ SENTRY_LOG_LEVEL=DEBUG SENTRY_PYTHON3=1 ./install.sh

Logs


    Creating sentry_onpremise_snuba-consumer_1              ... done
    Creating sentry_onpremise_snuba-transactions-consumer_1 ... done
    Creating sentry_onpremise_snuba-replacer_1              ... done
    Creating sentry_onpremise_web_run                       ... 
    Creating sentry_onpremise_web_run                       ... done
    !! Configuration error: error: argument for 's' must be a bytes object
    An error occurred, caught SIGERR on line 293
    Cleaning up...
@BYK
Copy link
Member

BYK commented Oct 19, 2020

Ooh, thanks for the report! Do you have an old config as a fresh install definitely works (CI tests this for each commit now).

If so can you share the config?

@BYK BYK added the needs-info label Oct 19, 2020
@ChillarAnand
Copy link
Author

ChillarAnand commented Oct 21, 2020

This is related to #692

I had an old config file which has strings instead of bytes. Updating the config file resolved the issue.

@BYK
Copy link
Member

BYK commented Oct 21, 2020

Closing then as this is a configuration issue.

@BYK BYK closed this as completed Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants