Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeId may need to preserve case, to work with case-sensitive symbol servers #9

Open
mstange opened this issue Sep 28, 2021 · 0 comments

Comments

@mstange
Copy link

mstange commented Sep 28, 2021

CodeId::new() currently calls make_ascii_lowercase():

rust-debugid/src/lib.rs

Lines 297 to 302 in 9fb71ae

/// Constructs a `CodeId` from its string representation.
pub fn new(mut string: String) -> Self {
string.retain(|c| c.is_ascii_hexdigit());
string.make_ascii_lowercase();
CodeId { inner: string }
}

However, the casing makes a difference when looking up exe/dll files on case-sensitive symbol servers. See getsentry/symbolic#436 for background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant