From 12fa493f0bb32c8d0ef50ebce2932df3041eddbb Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 15 Sep 2022 20:59:22 +0200 Subject: [PATCH 01/20] feat: add dangerJS workflow --- .github/workflows/danger-workflow-tests.yml | 9 ++ .github/workflows/danger.yml | 15 ++++ danger/dangerfile.js | 91 +++++++++++++++++++++ 3 files changed, 115 insertions(+) create mode 100644 .github/workflows/danger-workflow-tests.yml create mode 100644 .github/workflows/danger.yml create mode 100644 danger/dangerfile.js diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml new file mode 100644 index 0000000..86e5dc6 --- /dev/null +++ b/.github/workflows/danger-workflow-tests.yml @@ -0,0 +1,9 @@ +# This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. +name: Workflow Tests + +on: + push: + +jobs: + danger: + uses: ./.github/workflows/danger.yml diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml new file mode 100644 index 0000000..cce9edf --- /dev/null +++ b/.github/workflows/danger.yml @@ -0,0 +1,15 @@ +# Allows updating dependencies to the latest published tag +on: + workflow_call + +jobs: + danger: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + with: + fetch-depth: 0 + - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} + - run: npx danger ci --dangerfile {{ runner.temp }}/dangerfile.js + env: + GITHUB_TOKEN: ${{ github.token }} diff --git a/danger/dangerfile.js b/danger/dangerfile.js new file mode 100644 index 0000000..9e01a69 --- /dev/null +++ b/danger/dangerfile.js @@ -0,0 +1,91 @@ +// e.g. "feat" if PR title is "Feat : add more useful stuff" +// or "ci" if PR branch is "ci/update-danger" +function getPrFlavor() { + if (danger.github && danger.github.pr) { + var separator = undefined; + if (danger.github.pr.title) { + const parts = danger.github.pr.title.split(":"); + if (parts.length > 1) { + return parts[0].toLowerCase().trim(); + } + } + if (danger.github.pr.head && danger.github.pr.head.ref) { + const parts = danger.github.pr.head.ref.split("/"); + if (parts.length > 1) { + return parts[0].toLowerCase(); + } + } + } + return ""; +} + +async function checkDocs() { + if (getPrFlavor().startsWith("feat")) { + message( + 'Do not forget to update Sentry-docs with your feature once the pull request gets approved.' + ); + } +} + +async function checkChangelog() { + const changelogFile = "CHANGELOG.md"; + + // Check if skipped + if (danger.github && danger.github.pr) { + if ( + ["ci", "chore(deps)"].includes(getPrFlavor()) || + (danger.github.pr.body + "").includes("#skip-changelog") + ) { + return; + } + } + + // Check if current PR has an entry in changelog + const changelogContents = await danger.github.utils.fileContents( + changelogFile + ); + + const hasChangelogEntry = RegExp(`#${danger.github.pr.number}\\b`).test( + changelogContents + ); + + if (hasChangelogEntry) { + return; + } + + // Report missing changelog entry + fail( + "Please consider adding a changelog entry for the next release.", + changelogFile + ); + + const prTitleFormatted = danger.github.pr.title + .split(": ") + .slice(-1)[0] + .trim() + .replace(/\.+$/, ""); + + markdown( + ` +### Instructions and example for changelog + +Please add an entry to \`CHANGELOG.md\` to the "Unreleased" section. Make sure the entry includes this PR's number. + +Example: + +\`\`\`markdown +## Unreleased + +- ${prTitleFormatted} ([#${danger.github.pr.number}](${danger.github.pr.html_url})) +\`\`\` + +If none of the above apply, you can opt out of this check by adding \`#skip-changelog\` to the PR description.`.trim() + ); +} + +async function checkAll() { + await checkDocs(); + await checkChangelog(); +} + +schedule(checkAll); From 859deb4b1cfcd3a0f604d6551bedfa339e9d70b8 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 15 Sep 2022 21:24:20 +0200 Subject: [PATCH 02/20] chore: rename test workflows --- .github/workflows/danger-workflow-tests.yml | 2 +- .github/workflows/updater-scripts-tests.yml | 2 +- .github/workflows/updater-workflow-tests.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index 86e5dc6..d79a8e3 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -1,5 +1,5 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. -name: Workflow Tests +name: Danger Workflow Tests on: push: diff --git a/.github/workflows/updater-scripts-tests.yml b/.github/workflows/updater-scripts-tests.yml index 70d0737..f3650b0 100644 --- a/.github/workflows/updater-scripts-tests.yml +++ b/.github/workflows/updater-scripts-tests.yml @@ -1,5 +1,5 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test scripts. -name: Script Tests +name: Update Script Tests on: push: diff --git a/.github/workflows/updater-workflow-tests.yml b/.github/workflows/updater-workflow-tests.yml index a416b0f..aa029d3 100644 --- a/.github/workflows/updater-workflow-tests.yml +++ b/.github/workflows/updater-workflow-tests.yml @@ -1,5 +1,5 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. -name: Workflow Tests +name: Update Workflow Tests on: push: From f16da8edf2d7a2608e9125e26d15c8eba8e0cc80 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 15 Sep 2022 21:25:07 +0200 Subject: [PATCH 03/20] fix dangerfile path --- .github/workflows/danger.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index cce9edf..cf2650d 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -10,6 +10,6 @@ jobs: with: fetch-depth: 0 - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} - - run: npx danger ci --dangerfile {{ runner.temp }}/dangerfile.js + - run: npx danger ci --dangerfile ${{ runner.temp }}/dangerfile.js env: GITHUB_TOKEN: ${{ github.token }} From 3530284e77ea2ac65c1081402c66d04181f2e742 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 15 Sep 2022 21:42:34 +0200 Subject: [PATCH 04/20] refactor: fail danger on errors --- .github/workflows/danger-workflow-tests.yml | 3 +-- .github/workflows/danger.yml | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index d79a8e3..cb4116d 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -1,8 +1,7 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. name: Danger Workflow Tests -on: - push: +on: workflow_dispatch jobs: danger: diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index cf2650d..e04da1d 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -10,6 +10,6 @@ jobs: with: fetch-depth: 0 - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} - - run: npx danger ci --dangerfile ${{ runner.temp }}/dangerfile.js + - run: npx danger ci --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js env: GITHUB_TOKEN: ${{ github.token }} From 51f497e37f2e9d7c549c4626bb45e21c000b564c Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 15 Sep 2022 22:08:09 +0200 Subject: [PATCH 05/20] refactor: use danger-js docker image --- .github/workflows/danger.yml | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index e04da1d..9761933 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -9,7 +9,19 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} - - run: npx danger ci --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js - env: - GITHUB_TOKEN: ${{ github.token }} + + - name: Download dangerfile.js + run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} + + # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. + - name: Run DangerJS + run: | + docker run \ + --volume ${{ github.workspace }}:/workspace \ + --volume ${{ runner.temp }}:/ghwf \ + --workdir /workspace \ + --user $UID \ + --env-file <(env | grep XDG) \ + --env GITHUB_TOKEN="${{ github.token }}" \ + ghcr.io/danger/danger-js:11.1.2 \ + --failOnErrors --dangerfile ghwf/dangerfile.js From 5d74725c653fe23e03144b8f656920da40b79e19 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 15 Sep 2022 22:47:30 +0200 Subject: [PATCH 06/20] fix: danger workflow --- .github/workflows/danger-workflow-tests.yml | 3 ++- .github/workflows/danger.yml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index cb4116d..9c496c0 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -1,7 +1,8 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. name: Danger Workflow Tests -on: workflow_dispatch +# on: workflow_dispatch +on: push jobs: danger: diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 9761933..60036cf 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -21,7 +21,7 @@ jobs: --volume ${{ runner.temp }}:/ghwf \ --workdir /workspace \ --user $UID \ - --env-file <(env | grep XDG) \ + --env-file <(env) \ --env GITHUB_TOKEN="${{ github.token }}" \ ghcr.io/danger/danger-js:11.1.2 \ --failOnErrors --dangerfile ghwf/dangerfile.js From 8be3023c9484337414066b5599b0a469b8001a21 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 10:02:01 +0200 Subject: [PATCH 07/20] fix: danger docker rn --- .github/workflows/danger.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 60036cf..b833f71 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -17,11 +17,11 @@ jobs: - name: Run DangerJS run: | docker run \ - --volume ${{ github.workspace }}:/workspace \ - --volume ${{ runner.temp }}:/ghwf \ - --workdir /workspace \ + --volume ${{ github.workspace }}:${{ github.workspace }} \ + --volume ${{ runner.temp }}:${{ runner.temp }} \ + --workdir ${{ github.workspace }} \ --user $UID \ --env-file <(env) \ --env GITHUB_TOKEN="${{ github.token }}" \ ghcr.io/danger/danger-js:11.1.2 \ - --failOnErrors --dangerfile ghwf/dangerfile.js + --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js From d29a16f808863a9e059662a93a37268421a6554c Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 10:11:11 +0200 Subject: [PATCH 08/20] try dangerjs action --- .github/workflows/danger.yml | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index b833f71..0859369 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -13,15 +13,21 @@ jobs: - name: Download dangerfile.js run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} + - uses: danger/danger-js@11.1.2 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + with: + args: --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js + # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. - - name: Run DangerJS - run: | - docker run \ - --volume ${{ github.workspace }}:${{ github.workspace }} \ - --volume ${{ runner.temp }}:${{ runner.temp }} \ - --workdir ${{ github.workspace }} \ - --user $UID \ - --env-file <(env) \ - --env GITHUB_TOKEN="${{ github.token }}" \ - ghcr.io/danger/danger-js:11.1.2 \ - --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js + # - name: Run DangerJS + # run: | + # docker run \ + # --volume ${{ github.workspace }}:${{ github.workspace }} \ + # --volume ${{ runner.temp }}:${{ runner.temp }} \ + # --workdir ${{ github.workspace }} \ + # --user $UID \ + # --env-file <(env) \ + # --env GITHUB_TOKEN="${{ github.token }}" \ + # ghcr.io/danger/danger-js:11.1.2 \ + # --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js From 8b9a483a9dfe4c3425910305e36202a0561056e5 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 10:17:01 +0200 Subject: [PATCH 09/20] use default GHA docker run command --- .github/workflows/danger.yml | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 0859369..e5e5f46 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -13,21 +13,22 @@ jobs: - name: Download dangerfile.js run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} - - uses: danger/danger-js@11.1.2 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - args: --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js - # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. - # - name: Run DangerJS - # run: | - # docker run \ - # --volume ${{ github.workspace }}:${{ github.workspace }} \ - # --volume ${{ runner.temp }}:${{ runner.temp }} \ - # --workdir ${{ github.workspace }} \ - # --user $UID \ - # --env-file <(env) \ - # --env GITHUB_TOKEN="${{ github.token }}" \ - # ghcr.io/danger/danger-js:11.1.2 \ - # --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js + - name: Run DangerJS + run: | + docker run \ + --volume ${{ github.workspace }}:${{ github.workspace }} \ + --volume ${{ runner.temp }}:${{ runner.temp }} \ + --workdir ${{ github.workspace }} \ + --user $UID \ + -e "INPUT_ARGS" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ + -e GITHUB_TOKEN="${{ github.token }}" \ + ghcr.io/danger/danger-js:11.1.2 \ + --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js + + docker run + --workdir /github/workspace --rm + -v "/var/run/docker.sock":"/var/run/docker.sock" + -v "/home/runner/work/_temp/_github_home":"/github/home" + -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" + -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file From b0c8ee318af565a4374f500540ad624c6794555e Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 10:32:41 +0200 Subject: [PATCH 10/20] fix docker run --- .github/workflows/danger.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index e5e5f46..10dd33a 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -17,18 +17,19 @@ jobs: - name: Run DangerJS run: | docker run \ - --volume ${{ github.workspace }}:${{ github.workspace }} \ + --volume ${{ github.workspace }}:/github/workspace \ --volume ${{ runner.temp }}:${{ runner.temp }} \ - --workdir ${{ github.workspace }} \ + --workdir /github/workspace \ --user $UID \ - -e "INPUT_ARGS" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ + -e "INPUT_ARGS" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ -e GITHUB_TOKEN="${{ github.token }}" \ ghcr.io/danger/danger-js:11.1.2 \ --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js - docker run - --workdir /github/workspace --rm - -v "/var/run/docker.sock":"/var/run/docker.sock" - -v "/home/runner/work/_temp/_github_home":"/github/home" - -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" - -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file + # docker run + # --workdir /github/workspace --rm + # -v "/var/run/docker.sock":"/var/run/docker.sock" + # -v "/home/runner/work/_temp/_github_home":"/github/home" + # -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" + # -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" + # -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file From f77d3ec846390dbd1a3d62990c4fee58c2644a24 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 10:50:19 +0200 Subject: [PATCH 11/20] try GHA again --- .github/workflows/danger.yml | 42 ++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 10dd33a..719af82 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -11,25 +11,29 @@ jobs: fetch-depth: 0 - name: Download dangerfile.js - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} + run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ github.workspace }} + + - uses: danger/danger-js@11.1.2 + env: + GITHUB_TOKEN: ${{ github.token }} # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. - - name: Run DangerJS - run: | - docker run \ - --volume ${{ github.workspace }}:/github/workspace \ - --volume ${{ runner.temp }}:${{ runner.temp }} \ - --workdir /github/workspace \ - --user $UID \ - -e "INPUT_ARGS" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ - -e GITHUB_TOKEN="${{ github.token }}" \ - ghcr.io/danger/danger-js:11.1.2 \ - --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js + # - name: Run DangerJS + # run: | + # docker run \ + # --volume ${{ github.workspace }}:/github/workspace \ + # --volume ${{ runner.temp }}:${{ runner.temp }} \ + # --workdir /github/workspace \ + # --user $UID \ + # -e "INPUT_ARGS" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ + # -e GITHUB_TOKEN="${{ github.token }}" \ + # ghcr.io/danger/danger-js:11.1.2 \ + # --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js - # docker run - # --workdir /github/workspace --rm - # -v "/var/run/docker.sock":"/var/run/docker.sock" - # -v "/home/runner/work/_temp/_github_home":"/github/home" - # -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" - # -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" - # -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file + # # docker run + # # --workdir /github/workspace --rm + # # -v "/var/run/docker.sock":"/var/run/docker.sock" + # # -v "/home/runner/work/_temp/_github_home":"/github/home" + # # -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" + # # -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" + # # -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file From e7ff6ac748fd03f78f6698c3334569bc7176c4c4 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 10:57:38 +0200 Subject: [PATCH 12/20] fix danger run --- .github/workflows/danger.yml | 43 +++++++++++++++++------------------- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 719af82..ff82db5 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -11,29 +11,26 @@ jobs: fetch-depth: 0 - name: Download dangerfile.js - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ github.workspace }} - - - uses: danger/danger-js@11.1.2 - env: - GITHUB_TOKEN: ${{ github.token }} + run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. - # - name: Run DangerJS - # run: | - # docker run \ - # --volume ${{ github.workspace }}:/github/workspace \ - # --volume ${{ runner.temp }}:${{ runner.temp }} \ - # --workdir /github/workspace \ - # --user $UID \ - # -e "INPUT_ARGS" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ - # -e GITHUB_TOKEN="${{ github.token }}" \ - # ghcr.io/danger/danger-js:11.1.2 \ - # --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js + - name: Run DangerJS + run: | + docker run \ + --volume ${{ github.workspace }}:/github/workspace \ + --volume ${{ runner.temp }}:${{ runner.temp }} \ + --workdir /github/workspace \ + --user $UID \ + -e "INPUT_ARGS" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \ + -e GITHUB_TOKEN="${{ github.token }}" \ + -e DANGER_DISABLE_TRANSPILATION="true" \ + ghcr.io/danger/danger-js:11.1.2 \ + --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js - # # docker run - # # --workdir /github/workspace --rm - # # -v "/var/run/docker.sock":"/var/run/docker.sock" - # # -v "/home/runner/work/_temp/_github_home":"/github/home" - # # -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" - # # -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" - # # -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file + # docker run + # --workdir /github/workspace --rm + # -v "/var/run/docker.sock":"/var/run/docker.sock" + # -v "/home/runner/work/_temp/_github_home":"/github/home" + # -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" + # -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" + # -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file From 8e3aa3eb56cf048cfe71fd29c091c88e9b5799e9 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 11:10:35 +0200 Subject: [PATCH 13/20] chore: cleanup danger --- .github/workflows/danger-workflow-tests.yml | 5 +++-- .github/workflows/danger.yml | 8 -------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index 9c496c0..41a61c2 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -1,8 +1,9 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. name: Danger Workflow Tests -# on: workflow_dispatch -on: push +on: + pull_request: + types: [opened, synchronize, reopened, edited, ready_for_review] jobs: danger: diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index ff82db5..e0a5dd7 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -26,11 +26,3 @@ jobs: -e DANGER_DISABLE_TRANSPILATION="true" \ ghcr.io/danger/danger-js:11.1.2 \ --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js - - # docker run - # --workdir /github/workspace --rm - # -v "/var/run/docker.sock":"/var/run/docker.sock" - # -v "/home/runner/work/_temp/_github_home":"/github/home" - # -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" - # -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" - # -v "/home/runner/work/github-workflows/github-workflows":"/github/workspace" \ No newline at end of file From 0a7db9c196c9c0df662c44bb09604d79738ce1e9 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 11:16:23 +0200 Subject: [PATCH 14/20] chore: update docs --- .github/workflows/danger.yml | 2 +- README.md | 18 +++++++++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index e0a5dd7..8a1abe9 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,4 +1,4 @@ -# Allows updating dependencies to the latest published tag +# Runs DangerJS with a pre-configured set of rules on a Pull Request. on: workflow_call diff --git a/README.md b/README.md index 55e0a17..591a4c5 100644 --- a/README.md +++ b/README.md @@ -77,4 +77,20 @@ jobs: * `api-token`: GH authentication token to create PRs with & push. If you provide the usual `${{ github.token }}`, no followup CI will run on the created PR. - If you want CI to run on the PRs created by the Updater, you need to provide custom user-specific auth token. \ No newline at end of file + If you want CI to run on the PRs created by the Updater, you need to provide custom user-specific auth token. + +## Danger + +Runs DangerJS on Pull Reqeusts in your repository. This uses custom set of rules defined in [this dangerfile](danger/dangerfile.js). + +```yaml +name: Danger + +on: + pull_request: + types: [opened, synchronize, reopened, edited, ready_for_review] + +jobs: + danger: + uses: getsentry/github-workflows/.github/workflows/danger.yml@v2 +``` From fab20eba253d10a543f9585381c5db353215d561 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 11:17:55 +0200 Subject: [PATCH 15/20] chore: update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7c025b5..5317cab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Features + +- New Danger reusable workflow to check Pull Requests ([#34](https://github.com/getsentry/github-workflows/pull/34)) + ## 2.0.0 ### Changes From 01c8d25fc12432c5c79108ac85225fdc218cb007 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 11:28:23 +0200 Subject: [PATCH 16/20] ci: update workflow tests --- .github/workflows/danger-workflow-tests.yml | 6 ++++++ .github/workflows/danger.yml | 7 ++++++- .github/workflows/updater-scripts-tests.yml | 2 +- .github/workflows/updater-workflow-tests.yml | 2 +- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index 41a61c2..3630ccc 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -8,3 +8,9 @@ on: jobs: danger: uses: ./.github/workflows/danger.yml + + test-outputs: + runs-on: ubuntu-latest + needs: danger + steps: + - run: "[[ '${{ needs.danger.outputs.outcome }}' == 'success' ]]" \ No newline at end of file diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 8a1abe9..359e91f 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,6 +1,10 @@ # Runs DangerJS with a pre-configured set of rules on a Pull Request. on: - workflow_call + workflow_call: + outputs: + outcome: + description: Whether the Danger run finished successfully. Possible values are success, failure, cancelled, or skipped. + value: ${{ jobs.danger.steps.danger.outcome }} jobs: danger: @@ -15,6 +19,7 @@ jobs: # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. - name: Run DangerJS + id: danger run: | docker run \ --volume ${{ github.workspace }}:/github/workspace \ diff --git a/.github/workflows/updater-scripts-tests.yml b/.github/workflows/updater-scripts-tests.yml index f3650b0..854751a 100644 --- a/.github/workflows/updater-scripts-tests.yml +++ b/.github/workflows/updater-scripts-tests.yml @@ -1,5 +1,5 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test scripts. -name: Update Script Tests +name: Updater Script Tests on: push: diff --git a/.github/workflows/updater-workflow-tests.yml b/.github/workflows/updater-workflow-tests.yml index aa029d3..675a6a1 100644 --- a/.github/workflows/updater-workflow-tests.yml +++ b/.github/workflows/updater-workflow-tests.yml @@ -1,5 +1,5 @@ # This isn't a reusable workflow but an actual CI action for this repo itself - to test the workflows. -name: Update Workflow Tests +name: Updater Workflow Tests on: push: From b6c42b5722b9a6169806436ce2e8477674460f59 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 11:29:53 +0200 Subject: [PATCH 17/20] chore: fix danger output --- .github/workflows/danger-workflow-tests.yml | 2 +- .github/workflows/danger.yml | 4 +++- .github/workflows/versioning.yml | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index 3630ccc..dd9877a 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -13,4 +13,4 @@ jobs: runs-on: ubuntu-latest needs: danger steps: - - run: "[[ '${{ needs.danger.outputs.outcome }}' == 'success' ]]" \ No newline at end of file + - run: "[[ '${{ needs.danger.outputs.outcome }}' == 'success' ]]" diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 359e91f..e4f29e4 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -4,11 +4,13 @@ on: outputs: outcome: description: Whether the Danger run finished successfully. Possible values are success, failure, cancelled, or skipped. - value: ${{ jobs.danger.steps.danger.outcome }} + value: ${{ jobs.danger.outputs.outcome }} jobs: danger: runs-on: ubuntu-latest + outputs: + outcome: ${{ steps.danger.outcome }} steps: - uses: actions/checkout@v3 with: diff --git a/.github/workflows/versioning.yml b/.github/workflows/versioning.yml index ba8f779..41f86d4 100644 --- a/.github/workflows/versioning.yml +++ b/.github/workflows/versioning.yml @@ -1,4 +1,4 @@ -name: Keep the major version tags up-to-date +name: Sync tags with releases on: release: From 70bd9a4d53cfcc339628d5fc54a7d2b16d92032a Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 12:11:22 +0200 Subject: [PATCH 18/20] chore: update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5317cab..bf9a52e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Features -- New Danger reusable workflow to check Pull Requests ([#34](https://github.com/getsentry/github-workflows/pull/34)) +- New reusable workflow, `danger.yml`, to check Pull Requests with predefined rules ([#34](https://github.com/getsentry/github-workflows/pull/34)) ## 2.0.0 From 47d1facb867bced879112b1c047d238094539315 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 12:17:55 +0200 Subject: [PATCH 19/20] chore: update danger workflow version to v2 --- .github/workflows/danger-workflow-tests.yml | 2 ++ .github/workflows/danger.yml | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/danger-workflow-tests.yml b/.github/workflows/danger-workflow-tests.yml index dd9877a..0b27a3a 100644 --- a/.github/workflows/danger-workflow-tests.yml +++ b/.github/workflows/danger-workflow-tests.yml @@ -8,6 +8,8 @@ on: jobs: danger: uses: ./.github/workflows/danger.yml + with: + _workflow_version: ${{ github.sha }} test-outputs: runs-on: ubuntu-latest diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index e4f29e4..d2aa447 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,6 +1,12 @@ # Runs DangerJS with a pre-configured set of rules on a Pull Request. on: workflow_call: + inputs: + _workflow_version: + description: 'Internal: specify github-workflows (this repo) revision to use when checking out scripts.' + type: string + required: false + default: v2 # Note: update when publishing a new version outputs: outcome: description: Whether the Danger run finished successfully. Possible values are success, failure, cancelled, or skipped. @@ -17,7 +23,7 @@ jobs: fetch-depth: 0 - name: Download dangerfile.js - run: wget https://raw.githubusercontent.com/getsentry/github-workflows/feat/dangerjs/danger/dangerfile.js -P ${{ runner.temp }} + run: wget https://raw.githubusercontent.com/getsentry/github-workflows/${{ inputs._workflow_version }}/danger/dangerfile.js -P ${{ runner.temp }} # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors. - name: Run DangerJS From f67b411ba099eb89b08a704e89b5a215f46e2882 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 16 Sep 2022 12:20:28 +0200 Subject: [PATCH 20/20] chore: update changelog for v2.1.0 --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bf9a52e..82ba5f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +## 2.1.0 + ### Features - New reusable workflow, `danger.yml`, to check Pull Requests with predefined rules ([#34](https://github.com/getsentry/github-workflows/pull/34))