Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret scanner workflow fails to checkout code when PR is from fork #131

Closed
timfish opened this issue Jul 5, 2024 · 3 comments
Closed

Comments

@timfish
Copy link

timfish commented Jul 5, 2024

I'm guessing the issue is caused by the fork but I'm honestly not sure why it's failing here!

https://github.com/getsentry/sentry-electron/actions/runs/9793261370/job/27040829361?pr=937#step:3:61

@markstory
Copy link
Member

cc @getsentry/security

@geoffg-sentry
Copy link
Contributor

geoffg-sentry commented Jul 5, 2024

@timfish Odd one. It was the fetch that was failing on repeat:
git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=3 origin +refs/heads/feat/update-sdks*:refs/remotes/origin/feat/update-sdks* +refs/tags/feat/update-sdks*:refs/tags/feat/update-sdks*

Which itself was fine since it was properly referencing the refs from your fork. I re-ran the job and it passed without issue and that fetch returned as expected:

From https://github.com/getsentry/sentry-electron
[new branch]      feat/update-sdks -> origin/feat/update-sdks 

Your guess is as good as mine here.

@Jeffreyhung
Copy link
Member

The fetch depth was removed in the workflow, which should resolve any issues coming from a fork
#132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants