Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing all zeroes to the funnel visualization crashes the renderer #4529

Closed
susodapop opened this issue Jan 8, 2020 · 2 comments
Closed

Comments

@susodapop
Copy link
Contributor

Issue Summary

If all stages of a funnel chart return zero, the funnel chart crashes and takes the renderer with it. Adding this visualization to a dashboard makes the entire dashboard crash on load.

Steps to Reproduce

  1. In postgres use the following SQL:
SELECT * FROM (VALUES 
('foo', 0),
('bar', 0),
('baz', 0),
('foobar', 0)) data(stage,value)

It produces the following table:

stage value
foo 0
bar 0
baz 0
foobar 0
  1. Add a funnel visualization with the the stage and value columns.
  2. Observe the chart does not render.
  3. Save the visualization and try clicking the Edit Visualization button. It won't work.

This is probably a divide-by-zero error.

Technical details:

  • Redash Version: v9 Alpha
  • Browser/OS: FF
  • How did you install Redash: SaaS
@srs231198
Copy link

A simple check before any calculations should solve the issue... Do you still require assistance with this?

@susodapop
Copy link
Contributor Author

susodapop commented Jan 15, 2020

Thanks @srs231198. This has been solved already in the migration to React. Specifically this is fixed in #4267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants