Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cypress tests work with [email protected] #4286

Closed
arikfr opened this issue Oct 24, 2019 · 2 comments · Fixed by #4354
Closed

Make Cypress tests work with [email protected] #4286

arikfr opened this issue Oct 24, 2019 · 2 comments · Fixed by #4354
Assignees
Labels

Comments

@arikfr
Copy link
Member

arikfr commented Oct 24, 2019

Running our tests with [email protected] doesn't work. Need to figure out what happened, until then pinning the version to 3.4.1 (#4284).

@gabrieldutra gabrieldutra changed the title Make Cypress tests work with [email protected] Make Cypress tests work with [email protected] Nov 8, 2019
@gabrieldutra
Copy link
Member

After checking again the changelog list I think I finally found the cause for the issue 😁

I've read about changes in the cy.request command and "up to 2,000 characters of HTTP property values" and that remembered me of Chrome Logger issues with header size. I didn't bother to check deeper, but disabling it made the requests work again.

So @arikfr, how do you feel about the Chrome Logger? What passed through my mind was either use an env var to disable it in Cypress or use the server command instead of dev_server (there may be other implications on that which I'm not aware of, though). Also depending on its usage we can ✂️

I'm running the tests in the cypress-percy-update branch. (There seems to be still some other problems to fix, but the cy.request issue went away)

@arikfr
Copy link
Member Author

arikfr commented Nov 10, 2019

use the server command instead of dev_server (there may be other implications on that which I'm not aware of, though)

This sounds like a good idea in general. Unless it has some unwanted side effects, it provides a better environment for E2E testing.

Regardless, we should consider dropping Chrome Logger. I don't remember the last time I really used it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants