Broken link in initial (blank) Query Snippets page - missing organisation slug

[justinclift]

One of our users has reported the Query Snippets page has a broken link in the initial (unpopulated) placeholder content.

The Query Snippets page has a "New Query Snippet" button which works, and a text link in the list area to "Click here to add one".

The URL on the "Click here to add one" text is incorrect, missing the organisation slug.

eg: "https://myserver.org/query_snippets/new" instead of "https://myserver.org/myorganisation/query_snippets/new".

Looking at our code base, the problem seems to be our hard coded path here not adding the slug:

redash/client/app/pages/query-snippets/QuerySnippetsList.jsx

Line 155 in 75883a1

<a href="/query_snippets/new">Click here</a> to add one.

Hopefully this is a simple thing to fix. 😄

[gabrieldutra]

I've already started looking into this, I believe it's not a slug issue (it also happens in netlify's preview and I think the organization slug would be in the base url). This is a specific case for the logic I've introduced here. It works by avoiding the controller to be changed when changing the url, the issue is when you open the url /query_snippets/new directly. I'll push a fix for it later today as well as explaining it better 🙂.

[arikfr]

@gabrieldutra won't #4143 work? The other option I had in mind is just to use the onClick handler like we do with the button.

[gabrieldutra]

@gabrieldutra won't #4143 work? The other option I had in mind is just to use the onClick handler like we do with the button.

🤔 it's possible that what I tried was a different issue:

You can only click once in that, after that the link just stops working. It also happens if you open /query_snippets/new directly.

The onClick handler would probably work, though I was going in #4144 direction since we don't lose the ability to open in new tab (for query snippets it doesn't affect much, so not a big issue).

[arikfr]

Yeah, #4143 won't fix this one. Let's go with the onClick approach to reduce changes for something that isn't that important. Will you pdate #4144?