Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared dashboard footer should be always aligned to the bottom #3980

Closed
arikfr opened this issue Jul 15, 2019 · 2 comments · Fixed by #3984
Closed

Shared dashboard footer should be always aligned to the bottom #3980

arikfr opened this issue Jul 15, 2019 · 2 comments · Fixed by #3984
Assignees

Comments

@arikfr
Copy link
Member

arikfr commented Jul 15, 2019

When loading a public dashboard, before there is content to show, this is what the user sees:

image

  1. We need to align the footer to the bottom, even when there is no content.
  2. Add some loading indicator.
@ranbena
Copy link
Contributor

ranbena commented Jul 15, 2019

Is this happening in current master? How do I repro?

@arikfr
Copy link
Member Author

arikfr commented Jul 15, 2019

Yes. To reproduce you either add a delay in the time it takes to load a dashboard, or just comment out the following line:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants