You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've had a few issues in pull requests where the required Code Climate check hindered quick fixes and led to multiple code iterations to pass Code Climate's maintainability checks and effectively slowed down development.
Using Code Climate is great but should not create unnecessary refactoring churn (especially when the checked code isn't covered by automated tests). Instead we should loosen the analysis configuration to reflect the current state of the code.
See issues relating to the number of function arguments (5 instead of allowed 4) and line numbers per function (36 instead of allowed 25).
These are just examples of course, but I would consider those settings to be indicators of hard to maintain code since it leads to splitting app logic between many different callables and spaghetti code eventually.
Note, there are 10 maintainability checks in total that we need to review for practicability in this project.
The text was updated successfully, but these errors were encountered:
Issue Summary
We've had a few issues in pull requests where the required Code Climate check hindered quick fixes and led to multiple code iterations to pass Code Climate's maintainability checks and effectively slowed down development.
Using Code Climate is great but should not create unnecessary refactoring churn (especially when the checked code isn't covered by automated tests). Instead we should loosen the analysis configuration to reflect the current state of the code.
Steps to Reproduce
These are just examples of course, but I would consider those settings to be indicators of hard to maintain code since it leads to splitting app logic between many different callables and spaghetti code eventually.
Note, there are 10 maintainability checks in total that we need to review for practicability in this project.
The text was updated successfully, but these errors were encountered: