Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Scala2-Quill, dynamic batch actions are not supported (i.e. doing them will cause an error - see here) however, because they do not require and
inline def
, porting them to Scala 3 will result in a dynamic-batch-action with the same code as before. This was discovered original in the Quill testing codebase in the following: form:I.e. since
insertPeople
is not an inline def, it becomes dynamic in ProtoQuill. That means that if we don't support dynamic queries this code will not be portable.For this reason, I have decided to implement dynamic-batch-queries in ProtoQuill. This required an extensive refactoring of
BatchExecutionQuery.scala
.