Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bundle.images.* #41

Open
carolynvs opened this issue May 1, 2020 · 3 comments
Open

Support bundle.images.* #41

carolynvs opened this issue May 1, 2020 · 3 comments

Comments

@carolynvs
Copy link
Member

The porter.yaml file can have image maps defined and the templating supports referencing those images by name. It is currently a dictionary map (which none of the other types do, they are all lists with a name field).

Is it a huge pain to add support for this type as it works right now?

images:
  mysql:
      description: MySQL
      imageType: docker
      repository: docker.io/mysql
      tag: "5.7.28"

install:
- helm:
    description: "Install MySQL"
    name: "{{ bundle.parameters.mysql-name }}"
    set:
      image: "{{ bundle.images.mysql.repository }}"
      imageTag: "{{ bundle.images.mysql.tag }}"
@itowlson
Copy link
Collaborator

itowlson commented May 3, 2020

Depends what you mean by "support" grin... you mean something like wigglies if the image or field doesn't exist, and/or completion popups on the bundle.images. prefix?

@carolynvs
Copy link
Member Author

At the very least it shouldn't squiggle the text "bundle.images.NAME.*" with the porter_no_definition error. If I can have autocomplete that acts like how parameters work, that would be even better. 😁

@carolynvs
Copy link
Member Author

Attaching a pic of what it looks like when someone uses the bundle.images template syntax

Screen Shot 2023-01-09 at 9 19 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants