Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging Support #6

Closed
getnamo opened this issue Jul 25, 2019 · 7 comments
Closed

Packaging Support #6

getnamo opened this issue Jul 25, 2019 · 7 comments
Assignees
Labels

Comments

@getnamo
Copy link
Owner

getnamo commented Jul 25, 2019

Will likely need to add scripts folder to packaging like https://github.com/getnamo/tensorflow-ue4/blob/master/Source/TensorFlow/TensorFlow.Build.cs#L28

@getnamo getnamo added the enhancement New feature or request label Jul 25, 2019
@meignotn
Copy link

any ETA on this issues ? i tried to copy manualy the script folder into the package but it crashes

@helghast
Copy link

helghast commented Dec 21, 2019

any ETA on this issues ? i tried to copy manualy the script folder into the package but it crashes

I have the same problem.
Look at my message in the main thread: https://forums.unrealengine.com/community/work-in-progress/1644397-node-js

@getnamo
Copy link
Owner Author

getnamo commented Dec 23, 2019

I'll likely look into this issue sometime in January at earliest. In meantime the path is currently defined here: https://github.com/getnamo/nodejs-ue4/blob/master/Source/CommandLine/Private/NodeCmd.cpp#L40 changing this to reflect the location of the embedded ThirdParty/node content should suffice to make the plugin work in a packaged build (after copying third party folder over to that location after packaging)

NB: A proper fix would be to add a step in https://github.com/getnamo/nodejs-ue4/blob/master/Source/CommandLine/CommandLine.Build.cs to auto-copy the third party directory when packaging.

@qduborper
Copy link

Hello! thanks for the quickfix. The game now starts but not the server instance. Do I need also to copy the Scripts folder to content ?

thanks

@getnamo
Copy link
Owner Author

getnamo commented Jan 10, 2020

That sounds right. You should have both the third party folder and the scripts folder in the same relative folders as the project in the packaged folder for it to find everything

@getnamo
Copy link
Owner Author

getnamo commented Feb 23, 2020

Support added in 7fad399. Will land as the v0.5 release

Instructions for packaging are found here: https://github.com/getnamo/nodejs-ue4#packaging

  • you only need to add your project script folder to the additional assets to copy, all plugin related content gets automatically copied

@getnamo
Copy link
Owner Author

getnamo commented Feb 23, 2020

Closing with release: https://github.com/getnamo/nodejs-ue4/releases/tag/0.5.0, open new issue if new packaging issues appear

@getnamo getnamo closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants