Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] BaseURL support #46

Closed
flying-sausages opened this issue May 23, 2020 · 10 comments
Closed

[Feature Request] BaseURL support #46

flying-sausages opened this issue May 23, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@flying-sausages
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I would like to run mango behind a reverse proxy with a base url, i.e. <domain.tld>/mango instead of <domain.tld>:9000

Describe the solution you'd like
A line in the config.yml to set the baseurl

Additional context
Would be nice to have this included here too #43 (comment).
I'm struggling to do this right now with my nginx knwoledge

@flying-sausages flying-sausages added the enhancement New feature or request label May 23, 2020
@hkalexling
Copy link
Member

I think this SO question is what you are looking for? I use Apache so I couldn't test it for you.

@flying-sausages
Copy link
Collaborator Author

Been working on this this whole time and none of these answers do it for me. When I try access <domain.tld>/mango I get sent straight to <domain.tld>/login without mango in there. I'll update this if I find a good way to do this rewrite.

But ideally, there would be a similar option to this for example https://github.com/Flood-UI/flood/blob/master/config.template.js#L15

@hkalexling
Copy link
Member

Ah, you are right, I wasn't thinking clearly (missed my morning coffee). This should indeed be done in the application itself.

I saw your PR draft for the swizzin repo. I will prioritize this feature request so you can work on that soon.

@flying-sausages
Copy link
Collaborator Author

No stress! I appreciate the thought though :)

@hkalexling
Copy link
Member

Hi, base URL is now configurable in v0.4.0. Please check the Wiki for details.

I am closing this issue, but feel free to reopen.

@flying-sausages
Copy link
Collaborator Author

Heya, that was fast! I'm getting too many redirects right now however... https://termbin.com/pv7f

Did I do something wrong?

This is the config I am using. I'm getting the same when I use /mango and /mango/ in there
https://github.com/liaralabs/swizzin/pull/336/files#diff-92341616a03987b8325d9b8f89855792R38-R54

@flying-sausages
Copy link
Collaborator Author

Same when accessing localhost/mango with the nginx reverse proxy confed up https://termbin.com/51wrk

@flying-sausages
Copy link
Collaborator Author

also fwiw Issue author cannot re-open issue if maintainer closed them ;) isaacs/github#583

@hkalexling
Copy link
Member

I think it's because you missed the trailing slash in the Nginx config https://github.com/liaralabs/swizzin/pull/336/files#diff-3379b784c846d1072ebf4359a2074ba2R6

It should be proxy_pass http://localhost:9003/; instead.

Oops, I didn't know you cannot reopen. Thanks for letting me know! I will reopen this issue if the problem still persists after adding the slash.

@flying-sausages
Copy link
Collaborator Author

Yeah that's what's up. Cheers man, really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants