Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gocardless): Handle validation error with refund #2805

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix(gocardless): Handle validation error with refund #2805

merged 1 commit into from
Nov 12, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Context

This PR handle GoCardlessPro::ValidationError raised in the CreditNotes::Refunds::GocardlessCreateJob

Description

The PR makes sure that:

  • The credit note refund status is marked as failed
  • An error webhook is sent with the message coming from Gocardless
  • No error is returned by the service since it's not an issue but something that should be handled by the account owner.

@vincent-pochet vincent-pochet merged commit b6ada73 into main Nov 12, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the fix-gocardless-refund-validation branch November 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nudded nudded nudded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @nudded