Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Garage Widget #4315

Closed
wants to merge 1 commit into from
Closed

Feature: Garage Widget #4315

wants to merge 1 commit into from

Conversation

s0llvan
Copy link

@s0llvan s0llvan commented Nov 20, 2024

Proposed change

Add a Garage widget to display the health and status statistics of the nodes as well as the system.

Widget:

image

Garage:
curl --header "Authorization: Bearer kz8XSmZ8fgLDge5852pws/kvTTghzBQ95/ck1GuAbXc=" https://garage/v1/health

{
  "status": "healthy",
  "knownNodes": 2,
  "connectedNodes": 2,
  "storageNodes": 2,
  "storageNodesOk": 2,
  "partitions": 256,
  "partitionsQuorum": 256,
  "partitionsAllOk": 256
}

Closes #4314

Type of change

  • New service widget

Checklist:

@shamoon
Copy link
Collaborator

shamoon commented Nov 20, 2024

Please readdress if / when appropriate. Thanks

@shamoon shamoon closed this Nov 20, 2024
@s0llvan
Copy link
Author

s0llvan commented Nov 20, 2024

Please readdress if / when appropriate. Thanks

I don't understand, what's the problem...?

@shamoon
Copy link
Collaborator

shamoon commented Nov 20, 2024

Seems you checked the boxes but didn’t actually do the things. We require up-voted requests for widgets. Also at a quick glance looks like the widget doesn’t follow the guidelines

@s0llvan
Copy link
Author

s0llvan commented Nov 20, 2024

Seems you checked the boxes but didn’t actually do the things. We require up-voted requests for widgets. Also at a quick glance looks like the widget doesn’t follow the guidelines

I know for the up-votes, but it's just draft...and a discussion was created #4314

If I make a feature request and then wait for votes, someone else might have already submitted their pull request, as it has happened before, so I just anticipated by creating a draft...

I made a mistake on another widget guideline too, but it's a draft, so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants